Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1502168

Re: [PATCH] ARC-setup: Use seq_putc() in show_cpuinfo()

Show all headers | View raw

On 10/15/2016 12:56 PM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 15 Oct 2016 21:31:16 +0200
>
> A single character (line break) should be put into a sequence.
> Thus use the corresponding function "seq_putc".

Perhaps reword the changelog to say that seqc_putc is more efficient than
seqc_printf to output a single char.
I mean _printf is not wrong but not as efficient ?

>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  arch/arc/kernel/setup.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel/setup.c
> index 3df7f9c..e3f5432 100644
> --- a/arch/arc/kernel/setup.c
> +++ b/arch/arc/kernel/setup.c
> @@ -494,8 +494,7 @@ static int show_cpuinfo(struct seq_file *m, void *v)
>  
>  	free_page((unsigned long)str);
>  done:
> -	seq_printf(m, "\n");
> -
> +	seq_putc(m, '\n');
>  	return 0;
>  }
>  

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ARC-setup: Use seq_putc() in show_cpuinfo() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-15 22:00 +0200
  Re: [PATCH] ARC-setup: Use seq_putc() in show_cpuinfo() Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-10-17 18:30 +0200
    Re: ARC-setup: Use seq_putc() in show_cpuinfo() Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-10-17 19:30 +0200
      Re: ARC-setup: Use seq_putc() in show_cpuinfo() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-17 19:50 +0200
    Re: ARC-setup: Use seq_putc() in show_cpuinfo() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-17 19:30 +0200

csiph-web