Re: ARC-setup: Use seq_putc() in show_cpuinfo()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	Re: ARC-setup: Use seq_putc() in show_cpuinfo()
Date	2016-10-17 19:30 +0200
Message-ID	<stjTz-6sY-33@gated-at.bofh.it> (permalink)
References	<ssDhD-3Mr-5@gated-at.bofh.it> <stiXv-5Qr-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>> A single character (line break) should be put into a sequence.
>> Thus use the corresponding function "seq_putc".
> 
> Perhaps reword the changelog to say that seqc_putc is more efficient than
> seqc_printf to output a single char.
> I mean _printf is not wrong but not as efficient ?

I came along source files for a few other software modules with similar
change possibilities.
Unfortunately, the corresponding developers are not convinced yet
to replace a call of the function "seq_printf" at the end by
a "seq_putc" because of software efficiency reasons.

Do you find this update suggestion acceptable to some degree
for the function "setup"?

Regards,
Markus

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ARC-setup: Use seq_putc() in show_cpuinfo() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-15 22:00 +0200
  Re: [PATCH] ARC-setup: Use seq_putc() in show_cpuinfo() Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-10-17 18:30 +0200
    Re: ARC-setup: Use seq_putc() in show_cpuinfo() Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-10-17 19:30 +0200
      Re: ARC-setup: Use seq_putc() in show_cpuinfo() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-17 19:50 +0200
    Re: ARC-setup: Use seq_putc() in show_cpuinfo() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-17 19:30 +0200

csiph-web