Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1502295

Re: ARC-setup: Use seq_putc() in show_cpuinfo()

Show all headers | View raw

On 10/17/2016 10:19 AM, SF Markus Elfring wrote:
>>> A single character (line break) should be put into a sequence.
>>> Thus use the corresponding function "seq_putc".
>> Perhaps reword the changelog to say that seqc_putc is more efficient than
>> seqc_printf to output a single char.
>> I mean _printf is not wrong but not as efficient ?
> I came along source files for a few other software modules with similar
> change possibilities.
> Unfortunately, the corresponding developers are not convinced yet
> to replace a call of the function "seq_printf" at the end by
> a "seq_putc" because of software efficiency reasons.

I was ambivalent so far - but not anymore :-)
what is the objection - can you point me to a few links where people don't think
this is not a good idea.

> Do you find this update suggestion acceptable to some degree
> for the function "setup"?
>
> Regards,
> Markus
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ARC-setup: Use seq_putc() in show_cpuinfo() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-15 22:00 +0200
  Re: [PATCH] ARC-setup: Use seq_putc() in show_cpuinfo() Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-10-17 18:30 +0200
    Re: ARC-setup: Use seq_putc() in show_cpuinfo() Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-10-17 19:30 +0200
      Re: ARC-setup: Use seq_putc() in show_cpuinfo() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-17 19:50 +0200
    Re: ARC-setup: Use seq_putc() in show_cpuinfo() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-17 19:30 +0200

csiph-web