Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption

From	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption
Date	2016-10-17 10:00 +0200
Message-ID	<staZY-A3-31@gated-at.bofh.it> (permalink)
References	<ssAWt-2eM-13@gated-at.bofh.it> <stawW-pA-13@gated-at.bofh.it> <staGB-sN-11@gated-at.bofh.it> <staQh-wi-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 17 October 2016 at 08:47, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Mon, 2016-10-17 at 08:37 +0100, Ard Biesheuvel wrote:
>>
>> Could we get a statement first whether it is supported to allocate
>> aead_req (and other crypto req structures) on the stack?
>
> Well, we haven't heard from Herbert :)
>
>> If not, then
>> we have our work cut out for us. But if it is, I'd rather we didn't
>> apply the kzalloc/kfree patch, since it is just a workaround for the
>> broken generic CCM driver, for which a fix is already available.
>
> Yeah but I can't apply it. I just fixed up your kzalloc patch to also
> handle GCM and GMAC, and to have error checking. Will send it in a
> minute.
>

I just realised that patch should probably use
aead_request_alloc/aead_request_free [and drop the memset]. That also
fixes the latent bug where the alignment of the req ctx is not take
into account.

>> Also, regarding your __percpu patch: those are located in the vmalloc
>> area as well, at least on arm64, and likely other architectures too.
>
> Crap. Any other bright ideas?
>

kmem_cache_create() and kmem_cache_alloc()

Thread

[PATCH] crypto: ccm - avoid scatterlist for MAC encryption Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-15 19:30 +0200
  Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Johannes Berg <johannes@sipsolutions.net> - 2016-10-17 09:30 +0200
    Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-17 09:40 +0200
      Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Johannes Berg <johannes@sipsolutions.net> - 2016-10-17 09:50 +0200
        Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Johannes Berg <johannes@sipsolutions.net> - 2016-10-17 10:00 +0200
        Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-17 10:00 +0200
      Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Andy Lutomirski <luto@amacapital.net> - 2016-10-17 19:10 +0200
        Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-17 19:30 +0200
          Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Herbert Xu <herbert@gondor.apana.org.au> - 2016-10-19 05:40 +0200
            Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-19 17:10 +0200
              Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Ben Greear <greearb@candelatech.com> - 2016-10-19 18:00 +0200
                Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Johannes Berg <johannes@sipsolutions.net> - 2016-10-19 18:10 +0200
            Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Johannes Berg <johannes@sipsolutions.net> - 2016-10-19 17:50 +0200

csiph-web