Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption

From	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption
Date	2016-10-19 17:10 +0200
Message-ID	<su0Fb-2Wq-5@gated-at.bofh.it> (permalink)
References	(2 earlier) <staGB-sN-11@gated-at.bofh.it> <stjAf-6l5-77@gated-at.bofh.it> <stjTA-6sY-49@gated-at.bofh.it> <stPTs-3zU-1@gated-at.bofh.it> <su0Fb-2Wq-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 19 October 2016 at 08:43, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Wed, 2016-10-19 at 11:31 +0800, Herbert Xu wrote:
>> On Mon, Oct 17, 2016 at 06:21:14PM +0100, Ard Biesheuvel wrote:
>> >
>> >
>> > Annoyingly, all this complication with scatterlists etc is for
>> > doing
>> > asynchronous crypto via DMA capable crypto accelerators, and the
>> > networking code (ipsec as well as mac80211, afaik) only allow
>> > synchronous in the first place, given that they execute in softirq
>> > context.
>>
>> I'm still thinking about the issue (in particular, whether we
>> should continue to rely on the request context being SG-capable
>> or allow it to be on the stack for AEAD).
>
> :)
>
>> But IPsec definitely supports async crypto.  In fact it was the
>> very first user of async crypto.
>
> Yeah.
>

Ah yes, my bad.

>> mac80211 on the other hand is currently sync-only.
>
> We could probably make mac80211 do that too, but can we guarantee in-
> order processing? Anyway, it's pretty low priority, maybe never
> happening, since hardly anyone really uses "software" crypto, the wifi
> devices mostly have it built in anyway.
>

Indeed. The code is now correct in terms of API requirements, so let's
just wait for someone to complain about any performance regressions.

Thread

[PATCH] crypto: ccm - avoid scatterlist for MAC encryption Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-15 19:30 +0200
  Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Johannes Berg <johannes@sipsolutions.net> - 2016-10-17 09:30 +0200
    Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-17 09:40 +0200
      Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Johannes Berg <johannes@sipsolutions.net> - 2016-10-17 09:50 +0200
        Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Johannes Berg <johannes@sipsolutions.net> - 2016-10-17 10:00 +0200
        Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-17 10:00 +0200
      Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Andy Lutomirski <luto@amacapital.net> - 2016-10-17 19:10 +0200
        Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-17 19:30 +0200
          Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Herbert Xu <herbert@gondor.apana.org.au> - 2016-10-19 05:40 +0200
            Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-19 17:10 +0200
              Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Ben Greear <greearb@candelatech.com> - 2016-10-19 18:00 +0200
                Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Johannes Berg <johannes@sipsolutions.net> - 2016-10-19 18:10 +0200
            Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Johannes Berg <johannes@sipsolutions.net> - 2016-10-19 17:50 +0200

csiph-web