Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption

From	Johannes Berg <johannes@sipsolutions.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption
Date	2016-10-17 10:00 +0200
Message-ID	<staZY-A3-29@gated-at.bofh.it> (permalink)
References	(2 earlier) <staGB-sN-11@gated-at.bofh.it> <staQh-wi-7@gated-at.bofh.it> <staZY-A3-31@gated-at.bofh.it> <staZY-A3-33@gated-at.bofh.it> <staZY-A3-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 2016-10-17 at 08:50 +0100, Ard Biesheuvel wrote:

> I just realised that patch should probably use
> aead_request_alloc/aead_request_free [and drop the memset]. That also
> fixes the latent bug where the alignment of the req ctx is not take
> into account.

Good point, I'll fix that up.

> > 
> > > 
> > > Also, regarding your __percpu patch: those are located in the
> > > vmalloc
> > > area as well, at least on arm64, and likely other architectures
> > > too.
> > 
> > Crap. Any other bright ideas?
> > 
> 
> kmem_cache_create() and kmem_cache_alloc()

for the aad/b0/j0/etc? Hmm. Yeah I guess we should do those dynamically
as well then.

johannes

Thread

[PATCH] crypto: ccm - avoid scatterlist for MAC encryption Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-15 19:30 +0200
  Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Johannes Berg <johannes@sipsolutions.net> - 2016-10-17 09:30 +0200
    Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-17 09:40 +0200
      Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Johannes Berg <johannes@sipsolutions.net> - 2016-10-17 09:50 +0200
        Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Johannes Berg <johannes@sipsolutions.net> - 2016-10-17 10:00 +0200
        Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-17 10:00 +0200
      Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Andy Lutomirski <luto@amacapital.net> - 2016-10-17 19:10 +0200
        Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-17 19:30 +0200
          Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Herbert Xu <herbert@gondor.apana.org.au> - 2016-10-19 05:40 +0200
            Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-19 17:10 +0200
              Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Ben Greear <greearb@candelatech.com> - 2016-10-19 18:00 +0200
                Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Johannes Berg <johannes@sipsolutions.net> - 2016-10-19 18:10 +0200
            Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Johannes Berg <johannes@sipsolutions.net> - 2016-10-19 17:50 +0200

csiph-web