Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1501680

Re: linux-4.9-rc1/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c:1561: poor error checking ?

Show all headers | View raw

Hi David,
On Mon, 2016-10-17 at 07:40 +0000, David Binderman wrote:
> Hello there,
> 
> linux-4.9-rc1/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c:1561]: (style) Checking if unsigned variable 'len' is less than zero.
> 
> Source code is
> 
>     len = min((size_t)le32_to_cpu(rsp->len) << 2,
>           iwl_rx_packet_payload_len(hcmd.resp_pkt) - sizeof(*rsp));
>     len = min(len - delta, count);
>     if (len < 0) {
>         ret = -EFAULT;
>         goto out;
>     }
> 
> Suggest improve error checking.

Thanks for reporting! A fix for this is already queued in our internal
tree and will be sent upstream soon.

--
Cheers,
Luca.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re:  linux-4.9-rc1/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c:1561: poor  error checking ? Luca Coelho <luca@coelho.fi> - 2016-10-17 10:00 +0200

csiph-web