Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1500833

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

From Ard Biesheuvel <ard.biesheuvel@linaro.org>
Newsgroups linux.kernel
Subject Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)
Date 2016-10-14 13:20 +0200
Message-ID <ss8GS-zD-11@gated-at.bofh.it> (permalink)
References (18 earlier) <ss6OK-7Nf-11@gated-at.bofh.it> <ss6Yp-7QI-25@gated-at.bofh.it> <ss6Yp-7QI-23@gated-at.bofh.it> <ss785-7U4-5@gated-at.bofh.it> <ss7B7-8l7-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 14 October 2016 at 11:00, Johannes Berg <johannes@sipsolutions.net> wrote:
>
>> So why is the performance hit acceptable for ESP but not for WPA? We
>> could easily implement the same thing, i.e.,
>> kmalloc(GFP_ATOMIC)/kfree the aead_req struct rather than allocate it
>> on the stack
>
> Yeah, maybe we should. It's likely a much bigger allocation, but I
> don't actually know if that affects speed.
>
> In most cases where you want high performance we never hit this anyway
> since we'll have hardware crypto. I know for our (Intel's) devices we
> normally never hit these code paths.
>
> But on the other hand, you also did your changes for a reason, and the
> only reason I can see of that is performance. So you'd be the one with
> most "skin in the game", I guess?
>

Well, what sucks here is that the accelerated driver I implemented for
arm64 does not actually need this, as long as we take aad[] off the
stack. And note that the API was changed since my patch, to add aad[]
to the scatterlist: prior to this change, it used
aead_request_set_assoc() to set the associated data separately.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Andy Lutomirski <luto@amacapital.net> - 2016-10-13 08:10 +0200
  Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-13 08:10 +0200
    Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-10-13 15:50 +0200
      Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-10-13 16:10 +0200
      Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-13 16:20 +0200
        Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-10-13 17:10 +0200
          Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-10-13 17:30 +0200
        Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Andy Lutomirski <luto@amacapital.net> - 2016-10-14 00:00 +0200
          Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 09:30 +0200
            Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 10:30 +0200
              Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 10:40 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 10:50 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 11:00 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 11:10 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 11:20 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 11:30 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 11:40 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 12:10 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 13:20 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 11:30 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 10:50 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 10:50 +0200
            Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 11:00 +0200
          Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 10:50 +0200
          Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-10-14 10:50 +0200

csiph-web