Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1500764

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

From Johannes Berg <johannes@sipsolutions.net>
Newsgroups linux.kernel
Subject Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)
Date 2016-10-14 10:50 +0200
Message-ID <ss6lH-7od-9@gated-at.bofh.it> (permalink)
References (8 earlier) <srP1v-4Cs-21@gated-at.bofh.it> <srWcG-Ei-15@gated-at.bofh.it> <ss6lH-7od-11@gated-at.bofh.it> <ss6lH-7od-13@gated-at.bofh.it> <ss6lH-7od-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Fri, 2016-10-14 at 17:39 +0900, Sergey Senozhatsky wrote:
> 
> given that we have a known issue shouldn't VMAP_STACK be
> disabled for now, or would you rather prefer to mark MAC80211
> as incompatible: "depends on CFG80211 && !VMAP_STACK"?

Yeah. It's a bit complicated by the fact that most people will probably
have hardware crypto in their wifi NICs, so that they won't actually
hit the software crypto path. As I said in my other email though, we
can't guarantee - even if the driver says it can do hardware crypto -
that it really will do it for all frames (some might not be able to do
for management frames for example), so we also can't really catch this
at runtime ...

Making mac80211 depend on !VMAP_STACK is probably technically best, but
I fear it'll break a lot of people's configurations who don't have a
problem right now (e.g. Linus's, who probably enabled this, but I know
where he uses wifi he uses an Intel NIC that will always do HW crypto).

Andy, what do you think?

johannes

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Andy Lutomirski <luto@amacapital.net> - 2016-10-13 08:10 +0200
  Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-13 08:10 +0200
    Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-10-13 15:50 +0200
      Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-10-13 16:10 +0200
      Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-13 16:20 +0200
        Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-10-13 17:10 +0200
          Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-10-13 17:30 +0200
        Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Andy Lutomirski <luto@amacapital.net> - 2016-10-14 00:00 +0200
          Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 09:30 +0200
            Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 10:30 +0200
              Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 10:40 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 10:50 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 11:00 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 11:10 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 11:20 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 11:30 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 11:40 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 12:10 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 13:20 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 11:30 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 10:50 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 10:50 +0200
            Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 11:00 +0200
          Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 10:50 +0200
          Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-10-14 10:50 +0200

csiph-web