Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1500765

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

From Ard Biesheuvel <ard.biesheuvel@linaro.org>
Newsgroups linux.kernel
Subject Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)
Date 2016-10-14 10:50 +0200
Message-ID <ss6lH-7od-3@gated-at.bofh.it> (permalink)
References (10 earlier) <ss56h-6Hs-7@gated-at.bofh.it> <ss62m-7h9-11@gated-at.bofh.it> <ss6c2-7kv-29@gated-at.bofh.it> <ss6lH-7od-5@gated-at.bofh.it> <ss6lH-7od-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 14 October 2016 at 09:42, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Fri, 2016-10-14 at 09:41 +0100, Ard Biesheuvel wrote:
>
>> > I assume the stack buffer itself is not the problem here, but aad,
>> > which is allocated on the stack one frame up.
>> > Do we really need to revert the whole patch to fix that?
>>
>> Ah never mind, this is about 'odata'. Apologies, should have read
>> first
>
> Right, odata also goes into an sg list and further on.
>
> I think we should wait for Herbert to chime in before we do any further
> work though, perhaps he has any better ideas.
>

Do you have a reference for the sg_set_buf() call on odata?
crypto/ccm.c does not seem to have it (afaict), and the same problem
does not exist in the accelerated arm64 implementation. In the mean
time, I will try and see if we can move aad[] off the stack in the WPA
code.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Andy Lutomirski <luto@amacapital.net> - 2016-10-13 08:10 +0200
  Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-13 08:10 +0200
    Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-10-13 15:50 +0200
      Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-10-13 16:10 +0200
      Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-13 16:20 +0200
        Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-10-13 17:10 +0200
          Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-10-13 17:30 +0200
        Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Andy Lutomirski <luto@amacapital.net> - 2016-10-14 00:00 +0200
          Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 09:30 +0200
            Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 10:30 +0200
              Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 10:40 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 10:50 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 11:00 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 11:10 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 11:20 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 11:30 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 11:40 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 12:10 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 13:20 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 11:30 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 10:50 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 10:50 +0200
            Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 11:00 +0200
          Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 10:50 +0200
          Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-10-14 10:50 +0200

csiph-web