Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1500601

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

From Andy Lutomirski <luto@amacapital.net>
Newsgroups linux.kernel
Subject Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)
Date 2016-10-14 00:00 +0200
Message-ID <srWcG-Ei-15@gated-at.bofh.it> (permalink)
References (4 earlier) <srsHD-5Fa-1@gated-at.bofh.it> <srHnj-87T-5@gated-at.bofh.it> <srHnj-87T-19@gated-at.bofh.it> <srOyu-49a-29@gated-at.bofh.it> <srP1v-4Cs-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Oct 13, 2016 6:46 AM, "Johannes Berg" <johannes@sipsolutions.net> wrote:
>
> On Thu, 2016-10-13 at 22:42 +0900, Sergey Senozhatsky wrote:
> >
> > > > https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/commi
> > > > t/?h=x86/vmap_stack&id=0a39cfa6fbb5d5635c85253cc7d6b44b54822afd
> > > > https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/commi
> > > > t/?h=x86/vmap_stack&id=bf8cfa200b5a01383ea39fc8ce2f32909767baa8
> > >
> > > That truly sounds like something we'd rather avoid in the TX/RX
> > > paths though, which should perform well.
> >
> > didn't fix.
>
> It couldn't, since the new helpers weren't used in mac80211 in those
> patches yet.
>
> > so I finally had some time to do a better bug-reporter job.
> >
> > I added a bunch of printk-s and several virt_addr_valid()-s
> > to ieee80211_aes_ccm_encrypt().
> >
> > and right befoe the Oops I see the following report from
> > virt_addr_valid()
> >
> >
> >  FAIL: 00004100002cba02 > ffffc900802cba02 || 1 -> (00004100002cba02
> > >> 39) == 130
>
> Yeah, we already know that in this function the aad variable is on the
> stack, it explicitly is.
>
> The question, though, is why precisely that fails in the crypto code.
> Can you send the Oops report itself?
>

It's failing before that.  With CONFIG_VMAP_STACK=y, the stack may not
be physically contiguous and can't be used for DMA, so putting it in a
scatterlist is bogus in general, and the crypto code mostly wants a
scatterlist.

There are a couple (faster!) APIs for crypto that don't use
scatterlists, but I don't think AEAD works with them.

--Andy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Andy Lutomirski <luto@amacapital.net> - 2016-10-13 08:10 +0200
  Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-13 08:10 +0200
    Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-10-13 15:50 +0200
      Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-10-13 16:10 +0200
      Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-13 16:20 +0200
        Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-10-13 17:10 +0200
          Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-10-13 17:30 +0200
        Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Andy Lutomirski <luto@amacapital.net> - 2016-10-14 00:00 +0200
          Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 09:30 +0200
            Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 10:30 +0200
              Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 10:40 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 10:50 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 11:00 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 11:10 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 11:20 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 11:30 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 11:40 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 12:10 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 13:20 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 11:30 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 10:50 +0200
                Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 10:50 +0200
            Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 11:00 +0200
          Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 10:50 +0200
          Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-10-14 10:50 +0200

csiph-web