Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1500580

Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag

Show all headers | View raw

On Thu, Oct 13, 2016 at 01:41:11PM -0700, Vineeth Remanan Pillai wrote:

> Yes, the use case is out-of-tree and the code snippet above depicts the use
> .
> Since kern_path_locked is also not exported, out-of-tree code used kern_path
> for the existence check for directories.
> 
> One reference about this issue can be seen here.
> 
> http://www.gossamer-threads.com/lists/linux/kernel/2459690?do=post_view_flat#2459690

... and in that thread I have asked for details and got no reply whatsoever.
 
> We also have a customer who complained about this functionality change.
> 
> I understand that there has been no API promises been made to this API. But
> since this is an
> exported function, the change in function could cause break in out-of-tree
> kernel code. I will
> rephrase the commit message to say "change in functionality" instead of
> regression

In principle, I have no strong objections against exporting kern_path_locked,
provided it really matches what they (whoever they are) need.  I'm still
curious about the context, though - what is that code trying to do?  Depending
on the actual stuff it wants to implement, there might be better primitives
for doing that *and* there might be something worth adding and exporting
that would be a better match.

It's not that kern_path_locked() isn't a sane interface, but... using it
might be a sign of trying to work around something missing in API.  So again,
please post more details.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag Vineeth Remanan Pillai <vineethp@amazon.com> - 2016-10-13 22:00 +0200
  Re: [PATCH] namei: revert old behaviour for filename_lookup with  LOOKUP_PARENT flag Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-13 22:10 +0200
  Re: [PATCH] namei: revert old behaviour for filename_lookup with  LOOKUP_PARENT flag Christoph Hellwig <hch@infradead.org> - 2016-10-13 22:20 +0200
    Re: [PATCH] namei: revert old behaviour for filename_lookup with  LOOKUP_PARENT flag Christoph Hellwig <hch@infradead.org> - 2016-10-13 22:50 +0200
    Re: [PATCH] namei: revert old behaviour for filename_lookup with  LOOKUP_PARENT flag Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-13 22:50 +0200
      Re: [PATCH] namei: revert old behaviour for filename_lookup with  LOOKUP_PARENT flag Vineeth Remanan Pillai <vineethp@amazon.com> - 2016-10-13 22:50 +0200
        Re: [PATCH] namei: revert old behaviour for filename_lookup with  LOOKUP_PARENT flag Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-13 23:30 +0200
          Re: [PATCH] namei: revert old behaviour for filename_lookup with  LOOKUP_PARENT flag Vineeth Remanan Pillai <vineethp@amazon.com> - 2016-10-14 00:20 +0200
            Re: [PATCH] namei: revert old behaviour for filename_lookup with  LOOKUP_PARENT flag Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-14 01:40 +0200
              RE: [PATCH] namei: revert old behaviour for filename_lookup with  LOOKUP_PARENT flag "Remanan Pillai, Vineeth" <vineethp@amazon.com> - 2016-10-14 02:10 +0200

csiph-web