Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1500527
| From | Al Viro <viro@ZenIV.linux.org.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag |
| Date | 2016-10-13 22:10 +0200 |
| Message-ID | <srUud-8eQ-9@gated-at.bofh.it> (permalink) |
| References | <srUkx-7Wj-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Oct 13, 2016 at 07:58:51PM +0000, Vineeth Remanan Pillai wrote:
> filename_lookup used to return success for non-existing file when called
> with LOOKUP_PARENT flag. This behaviour was changed with
> commit 8bcb77fabd7c ("namei: split off filename_lookupat()
> with LOOKUP_PARENT")
>
> The above patch split parent lookup functionality to a different function
> filename_parentat and changed all calls to filename_lookup(LOOKUP_PARENT)
> to the new function filename_parentat. But functions like kern_path which
> passed the flags directly to filename_lookup regressed due to this.
>
> This patch aims to fix the regressed behaviour by calling
> filename_parentat from filename_lookup if the flags contain LOOKUP_PARENT.
What would we want that for? Details, please. In particular, I would like
to know how to use that in non-racy way. What are you doing with it?
PS: "regressed" assumes that there had been any promise of API stability;
no such thing has ever existed.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag Vineeth Remanan Pillai <vineethp@amazon.com> - 2016-10-13 22:00 +0200
Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-13 22:10 +0200
Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag Christoph Hellwig <hch@infradead.org> - 2016-10-13 22:20 +0200
Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag Christoph Hellwig <hch@infradead.org> - 2016-10-13 22:50 +0200
Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-13 22:50 +0200
Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag Vineeth Remanan Pillai <vineethp@amazon.com> - 2016-10-13 22:50 +0200
Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-13 23:30 +0200
Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag Vineeth Remanan Pillai <vineethp@amazon.com> - 2016-10-14 00:20 +0200
Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-14 01:40 +0200
RE: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag "Remanan Pillai, Vineeth" <vineethp@amazon.com> - 2016-10-14 02:10 +0200
csiph-web