Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1500530

Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag

From Christoph Hellwig <hch@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag
Date 2016-10-13 22:20 +0200
Message-ID <srUDU-8id-19@gated-at.bofh.it> (permalink)
References <srUkx-7Wj-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Oct 13, 2016 at 07:58:51PM +0000, Vineeth Remanan Pillai wrote:
> filename_lookup used to return success for non-existing file when called
> with LOOKUP_PARENT flag. This behaviour was changed with
> commit 8bcb77fabd7c ("namei: split off filename_lookupat()
> with LOOKUP_PARENT")
> 
> The above patch split parent lookup functionality to a different function
> filename_parentat and changed all calls to filename_lookup(LOOKUP_PARENT)
> to the new function filename_parentat. But functions like kern_path which
> passed the flags directly to filename_lookup regressed due to this.
> 
> This patch aims to fix the regressed behaviour by calling
> filename_parentat from filename_lookup if the flags contain LOOKUP_PARENT.

What callers shows te problems?  That's probaby were the fix need to got
in, and even if not that's still part of a good bug report.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag Vineeth Remanan Pillai <vineethp@amazon.com> - 2016-10-13 22:00 +0200
  Re: [PATCH] namei: revert old behaviour for filename_lookup with  LOOKUP_PARENT flag Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-13 22:10 +0200
  Re: [PATCH] namei: revert old behaviour for filename_lookup with  LOOKUP_PARENT flag Christoph Hellwig <hch@infradead.org> - 2016-10-13 22:20 +0200
    Re: [PATCH] namei: revert old behaviour for filename_lookup with  LOOKUP_PARENT flag Christoph Hellwig <hch@infradead.org> - 2016-10-13 22:50 +0200
    Re: [PATCH] namei: revert old behaviour for filename_lookup with  LOOKUP_PARENT flag Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-13 22:50 +0200
      Re: [PATCH] namei: revert old behaviour for filename_lookup with  LOOKUP_PARENT flag Vineeth Remanan Pillai <vineethp@amazon.com> - 2016-10-13 22:50 +0200
        Re: [PATCH] namei: revert old behaviour for filename_lookup with  LOOKUP_PARENT flag Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-13 23:30 +0200
          Re: [PATCH] namei: revert old behaviour for filename_lookup with  LOOKUP_PARENT flag Vineeth Remanan Pillai <vineethp@amazon.com> - 2016-10-14 00:20 +0200
            Re: [PATCH] namei: revert old behaviour for filename_lookup with  LOOKUP_PARENT flag Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-14 01:40 +0200
              RE: [PATCH] namei: revert old behaviour for filename_lookup with  LOOKUP_PARENT flag "Remanan Pillai, Vineeth" <vineethp@amazon.com> - 2016-10-14 02:10 +0200

csiph-web