Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1500581
| From | Sean Young <sean@mess.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] [media] dib0700: fix nec repeat handling |
| Date | 2016-10-13 23:30 +0200 |
| Message-ID | <srVJD-u5-5@gated-at.bofh.it> (permalink) |
| References | <srOI9-4cr-1@gated-at.bofh.it> <srVJD-u5-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
When receiving a nec repeat, ensure the correct scancode is repeated
rather than a random value from the stack. This removes the need
for the bogus uninitialized_var() and also fixes the warnings:
drivers/media/usb/dvb-usb/dib0700_core.c: In function ‘dib0700_rc_urb_completion’:
drivers/media/usb/dvb-usb/dib0700_core.c:679: warning: ‘protocol’ may be used uninitialized in this function
Signed-off-by: Sean Young <sean@mess.org>
---
drivers/media/usb/dvb-usb/dib0700_core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media/usb/dvb-usb/dib0700_core.c b/drivers/media/usb/dvb-usb/dib0700_core.c
index f319665..5bb23ef 100644
--- a/drivers/media/usb/dvb-usb/dib0700_core.c
+++ b/drivers/media/usb/dvb-usb/dib0700_core.c
@@ -677,7 +677,7 @@ static void dib0700_rc_urb_completion(struct urb *purb)
struct dvb_usb_device *d = purb->context;
struct dib0700_rc_response *poll_reply;
enum rc_type protocol;
- u32 uninitialized_var(keycode);
+ u32 keycode;
u8 toggle;
deb_info("%s()\n", __func__);
@@ -718,7 +718,8 @@ static void dib0700_rc_urb_completion(struct urb *purb)
poll_reply->nec.data == 0x00 &&
poll_reply->nec.not_data == 0xff) {
poll_reply->data_state = 2;
- break;
+ rc_repeat(d->rc_dev);
+ goto resubmit;
}
if ((poll_reply->nec.data ^ poll_reply->nec.not_data) != 0xff) {
--
2.7.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] [media] dib0700: Fix uninitialized protocol for NEC repeat codes Geert Uytterhoeven <geert@linux-m68k.org> - 2016-10-13 16:00 +0200 [PATCH] [media] dib0700: fix nec repeat handling Sean Young <sean@mess.org> - 2016-10-13 23:30 +0200 Re: [PATCH] [media] dib0700: Fix uninitialized protocol for NEC repeat codes Sean Young <sean@mess.org> - 2016-10-13 23:30 +0200
csiph-web