Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1494429
| From | Sinan Kaya <okaya@codeaurora.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V4 04/10] dmaengine: qcom_hidma: configure DMA and MSI for OF |
| Date | 2016-10-01 17:20 +0200 |
| Message-ID | <snuf0-1Sl-11@gated-at.bofh.it> (permalink) |
| References | <smz73-6wm-3@gated-at.bofh.it> <smz74-6wm-17@gated-at.bofh.it> <snlEK-4sh-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 10/1/2016 2:17 AM, Vinod Koul wrote: > On Wed, Sep 28, 2016 at 10:12:41PM -0400, Sinan Kaya wrote: >> Configure the DMA bindings for the device tree based firmware. >> >> Signed-off-by: Sinan Kaya <okaya@codeaurora.org> >> --- >> drivers/dma/qcom/hidma_mgmt.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/dma/qcom/hidma_mgmt.c b/drivers/dma/qcom/hidma_mgmt.c >> index 82f36e4..e8f6b84 100644 >> --- a/drivers/dma/qcom/hidma_mgmt.c >> +++ b/drivers/dma/qcom/hidma_mgmt.c >> @@ -375,8 +375,11 @@ static int __init hidma_mgmt_of_populate_channels(struct device_node *np) >> ret = PTR_ERR(new_pdev); >> goto out; >> } >> + of_node_get(child); >> + new_pdev->dev.of_node = child; >> of_dma_configure(&new_pdev->dev, child); >> - >> + of_msi_configure(&new_pdev->dev, child); >> + of_node_put(child); > > should this be done unconditionally? Dont we needto call this only for > platforms with msi? I followed the pattern in of_platform_device_create_pdata function. of_msi_configure does nothing if MSI is not enabled as irq_find_matching_host returns NULL. It didn't have any side effects on my testing either. > >> kfree(res); >> res = NULL; >> } >> -- >> 1.9.1 >> > -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V4 04/10] dmaengine: qcom_hidma: configure DMA and MSI for OF Sinan Kaya <okaya@codeaurora.org> - 2016-09-29 04:20 +0200
Re: [PATCH V4 04/10] dmaengine: qcom_hidma: configure DMA and MSI for OF Vinod Koul <vinod.koul@intel.com> - 2016-10-01 08:10 +0200
Re: [PATCH V4 04/10] dmaengine: qcom_hidma: configure DMA and MSI for OF Sinan Kaya <okaya@codeaurora.org> - 2016-10-01 17:20 +0200
Re: [PATCH V4 04/10] dmaengine: qcom_hidma: configure DMA and MSI for OF Vinod Koul <vinod.koul@intel.com> - 2016-10-03 05:40 +0200
Re: [PATCH V4 04/10] dmaengine: qcom_hidma: configure DMA and MSI for OF Sinan Kaya <okaya@codeaurora.org> - 2016-10-03 15:40 +0200
csiph-web