Re: [PATCH V4 04/10] dmaengine: qcom_hidma: configure DMA and MSI for OF

From	Sinan Kaya <okaya@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V4 04/10] dmaengine: qcom_hidma: configure DMA and MSI for OF
Date	2016-10-03 15:40 +0200
Message-ID	<sobDj-5y2-17@gated-at.bofh.it> (permalink)
References	<smz73-6wm-3@gated-at.bofh.it> <smz74-6wm-17@gated-at.bofh.it> <snlEK-4sh-5@gated-at.bofh.it> <snuf0-1Sl-11@gated-at.bofh.it> <so2gG-79T-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10/2/2016 11:38 PM, Vinod Koul wrote:
>> I followed the pattern in of_platform_device_create_pdata function. of_msi_configure does
>> > nothing if MSI is not enabled as irq_find_matching_host returns NULL. It didn't have any
>> > side effects on my testing either.
> yeah later on I did look up the of_msi_configure() and I suspected this. I
> think it would be worthwhile to document this assumption here.

Sure, let me do that.

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V4 04/10] dmaengine: qcom_hidma: configure DMA and MSI for OF Sinan Kaya <okaya@codeaurora.org> - 2016-09-29 04:20 +0200
  Re: [PATCH V4 04/10] dmaengine: qcom_hidma: configure DMA and MSI  for OF Vinod Koul <vinod.koul@intel.com> - 2016-10-01 08:10 +0200
    Re: [PATCH V4 04/10] dmaengine: qcom_hidma: configure DMA and MSI for  OF Sinan Kaya <okaya@codeaurora.org> - 2016-10-01 17:20 +0200
      Re: [PATCH V4 04/10] dmaengine: qcom_hidma: configure DMA and MSI  for OF Vinod Koul <vinod.koul@intel.com> - 2016-10-03 05:40 +0200
        Re: [PATCH V4 04/10] dmaengine: qcom_hidma: configure DMA and MSI for  OF Sinan Kaya <okaya@codeaurora.org> - 2016-10-03 15:40 +0200

csiph-web