Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1480713

[PATCH 11/13] DRBD-receiver: Improve a size determination in receive_protocol()

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject [PATCH 11/13] DRBD-receiver: Improve a size determination in receive_protocol()
Date 2016-09-10 22:40 +0200
Message-ID <sfXea-4SK-23@gated-at.bofh.it> (permalink)
References <sfX4t-4Pv-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 10 Sep 2016 22:02:11 +0200

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/block/drbd/drbd_receiver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
index 3e1315a..bbccdb8 100644
--- a/drivers/block/drbd/drbd_receiver.c
+++ b/drivers/block/drbd/drbd_receiver.c
@@ -3697,7 +3697,7 @@ static int receive_protocol(struct drbd_connection *connection, struct packet_in
 		}
 	}
 
-	new_net_conf = kmalloc(sizeof(struct net_conf), GFP_KERNEL);
+	new_net_conf = kmalloc(sizeof(*new_net_conf), GFP_KERNEL);
 	if (!new_net_conf) {
 		drbd_err(connection, "Allocation of new net_conf failed\n");
 		goto disconnect;
-- 
2.10.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 00/13] DRBD-receiver: Fine-tuning for six function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:30 +0200
  [PATCH 01/13] DRBD-receiver: Use kmalloc_array() in receive_uuids() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:30 +0200
  [PATCH 06/13] DRBD-receiver: Improve a size determination in  receive_sizes() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:30 +0200
  [PATCH 03/13] DRBD-receiver: Move an assignment in receive_uuids() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:30 +0200
  [PATCH 10/13] DRBD-receiver: Delete error messages for failed  resource allocations in receive_SyncParam() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200
  [PATCH 08/13] DRBD-receiver: Move an assignment in receive_sizes() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200
  [PATCH 13/13] DRBD-receiver: Improve determination of sizes in  receive_Barrier() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200
  [PATCH 09/13] DRBD-receiver: Improve determination of sizes in  receive_SyncParam() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200
  [PATCH 12/13] DRBD-receiver: Delete error messages for failed  resource allocations in receive_protocol() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200
  [PATCH 11/13] DRBD-receiver: Improve a size determination in  receive_protocol() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200
  [PATCH 07/13] DRBD-receiver: Delete an error message for a failed  kzalloc() call in receive_sizes() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200

csiph-web