Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1480707
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 03/13] DRBD-receiver: Move an assignment in receive_uuids() |
| Date | 2016-09-10 22:30 +0200 |
| Message-ID | <sfX4t-4Pv-25@gated-at.bofh.it> (permalink) |
| References | <sfX4t-4Pv-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 10 Sep 2016 19:37:42 +0200
Move one assignment for the local variable "updated_uuids" so that
its setting will only be performed after corresponding memory
allocations succeeded by this function.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/block/drbd/drbd_receiver.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
index dab3f74..5526f6b 100644
--- a/drivers/block/drbd/drbd_receiver.c
+++ b/drivers/block/drbd/drbd_receiver.c
@@ -4179,7 +4179,7 @@ static int receive_uuids(struct drbd_connection *connection, struct packet_info
struct drbd_device *device;
struct p_uuids *p = pi->data;
u64 *p_uuid;
- int i, updated_uuids = 0;
+ int i, updated_uuids;
peer_device = conn_peer_device(connection, pi->vnr);
if (!peer_device)
@@ -4206,6 +4206,7 @@ static int receive_uuids(struct drbd_connection *connection, struct packet_info
return -EIO;
}
+ updated_uuids = 0;
if (get_ldev(device)) {
int skip_initial_sync =
device->state.conn == C_CONNECTED &&
--
2.10.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/13] DRBD-receiver: Fine-tuning for six function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:30 +0200 [PATCH 01/13] DRBD-receiver: Use kmalloc_array() in receive_uuids() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:30 +0200 [PATCH 06/13] DRBD-receiver: Improve a size determination in receive_sizes() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:30 +0200 [PATCH 03/13] DRBD-receiver: Move an assignment in receive_uuids() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:30 +0200 [PATCH 10/13] DRBD-receiver: Delete error messages for failed resource allocations in receive_SyncParam() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200 [PATCH 08/13] DRBD-receiver: Move an assignment in receive_sizes() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200 [PATCH 13/13] DRBD-receiver: Improve determination of sizes in receive_Barrier() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200 [PATCH 09/13] DRBD-receiver: Improve determination of sizes in receive_SyncParam() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200 [PATCH 12/13] DRBD-receiver: Delete error messages for failed resource allocations in receive_protocol() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200 [PATCH 11/13] DRBD-receiver: Improve a size determination in receive_protocol() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200 [PATCH 07/13] DRBD-receiver: Delete an error message for a failed kzalloc() call in receive_sizes() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200
csiph-web