Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1480709

[PATCH 08/13] DRBD-receiver: Move an assignment in receive_sizes()

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject [PATCH 08/13] DRBD-receiver: Move an assignment in receive_sizes()
Date 2016-09-10 22:40 +0200
Message-ID <sfXea-4SK-15@gated-at.bofh.it> (permalink)
References <sfX4t-4Pv-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 10 Sep 2016 21:50:18 +0200

Move one assignment for the local variable "ldsc" so that its setting
will only be performed after corresponding data processing succeeded
by this function.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/block/drbd/drbd_receiver.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
index 6a9c16e..2fe58d1 100644
--- a/drivers/block/drbd/drbd_receiver.c
+++ b/drivers/block/drbd/drbd_receiver.c
@@ -4036,7 +4036,7 @@ static int receive_sizes(struct drbd_connection *connection, struct packet_info
 	struct o_qlim *o = (connection->agreed_features & DRBD_FF_WSAME) ? p->qlim : NULL;
 	enum determine_dev_size dd = DS_UNCHANGED;
 	sector_t p_size, p_usize, p_csize, my_usize;
-	int ldsc = 0; /* local disk size changed */
+	int ldsc; /* local disk size changed */
 	enum dds_flags ddsf;
 
 	peer_device = conn_peer_device(connection, pi->vnr);
@@ -4141,6 +4141,7 @@ static int receive_sizes(struct drbd_connection *connection, struct packet_info
 		drbd_set_my_capacity(device, p_csize ?: p_usize ?: p_size);
 	}
 
+	ldsc = 0;
 	if (get_ldev(device)) {
 		if (device->ldev->known_size != drbd_get_capacity(device->ldev->backing_bdev)) {
 			device->ldev->known_size = drbd_get_capacity(device->ldev->backing_bdev);
-- 
2.10.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 00/13] DRBD-receiver: Fine-tuning for six function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:30 +0200
  [PATCH 01/13] DRBD-receiver: Use kmalloc_array() in receive_uuids() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:30 +0200
  [PATCH 06/13] DRBD-receiver: Improve a size determination in  receive_sizes() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:30 +0200
  [PATCH 03/13] DRBD-receiver: Move an assignment in receive_uuids() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:30 +0200
  [PATCH 10/13] DRBD-receiver: Delete error messages for failed  resource allocations in receive_SyncParam() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200
  [PATCH 08/13] DRBD-receiver: Move an assignment in receive_sizes() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200
  [PATCH 13/13] DRBD-receiver: Improve determination of sizes in  receive_Barrier() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200
  [PATCH 09/13] DRBD-receiver: Improve determination of sizes in  receive_SyncParam() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200
  [PATCH 12/13] DRBD-receiver: Delete error messages for failed  resource allocations in receive_protocol() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200
  [PATCH 11/13] DRBD-receiver: Improve a size determination in  receive_protocol() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200
  [PATCH 07/13] DRBD-receiver: Delete an error message for a failed  kzalloc() call in receive_sizes() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200

csiph-web