Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1480711
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 09/13] DRBD-receiver: Improve determination of sizes in receive_SyncParam() |
| Date | 2016-09-10 22:40 +0200 |
| Message-ID | <sfXea-4SK-19@gated-at.bofh.it> (permalink) |
| References | <sfX4t-4Pv-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 10 Sep 2016 21:54:55 +0200
Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/block/drbd/drbd_receiver.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
index 2fe58d1..6fbd968 100644
--- a/drivers/block/drbd/drbd_receiver.c
+++ b/drivers/block/drbd/drbd_receiver.c
@@ -3859,7 +3859,7 @@ static int receive_SyncParam(struct drbd_connection *connection, struct packet_i
mutex_lock(&connection->resource->conf_update);
old_net_conf = peer_device->connection->net_conf;
if (get_ldev(device)) {
- new_disk_conf = kzalloc(sizeof(struct disk_conf), GFP_KERNEL);
+ new_disk_conf = kzalloc(sizeof(*new_disk_conf), GFP_KERNEL);
if (!new_disk_conf) {
put_ldev(device);
mutex_unlock(&connection->resource->conf_update);
@@ -3946,7 +3946,8 @@ static int receive_SyncParam(struct drbd_connection *connection, struct packet_i
}
if (verify_tfm || csums_tfm) {
- new_net_conf = kzalloc(sizeof(struct net_conf), GFP_KERNEL);
+ new_net_conf = kzalloc(sizeof(*new_net_conf),
+ GFP_KERNEL);
if (!new_net_conf) {
drbd_err(device, "Allocation of new net_conf failed\n");
goto disconnect;
--
2.10.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/13] DRBD-receiver: Fine-tuning for six function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:30 +0200 [PATCH 01/13] DRBD-receiver: Use kmalloc_array() in receive_uuids() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:30 +0200 [PATCH 06/13] DRBD-receiver: Improve a size determination in receive_sizes() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:30 +0200 [PATCH 03/13] DRBD-receiver: Move an assignment in receive_uuids() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:30 +0200 [PATCH 10/13] DRBD-receiver: Delete error messages for failed resource allocations in receive_SyncParam() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200 [PATCH 08/13] DRBD-receiver: Move an assignment in receive_sizes() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200 [PATCH 13/13] DRBD-receiver: Improve determination of sizes in receive_Barrier() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200 [PATCH 09/13] DRBD-receiver: Improve determination of sizes in receive_SyncParam() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200 [PATCH 12/13] DRBD-receiver: Delete error messages for failed resource allocations in receive_protocol() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200 [PATCH 11/13] DRBD-receiver: Improve a size determination in receive_protocol() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200 [PATCH 07/13] DRBD-receiver: Delete an error message for a failed kzalloc() call in receive_sizes() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 22:40 +0200
csiph-web