Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1549767
| From | David Hildenbrand <david@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 4/6] KVM: x86: refactor pic setup in kvm_set_routing_entry |
| Date | 2017-01-03 14:10 +0100 |
| Message-ID | <sVx0J-6NW-15@gated-at.bofh.it> (permalink) |
| References | <sP2sF-5nI-3@gated-at.bofh.it> <sP2sG-5nI-43@gated-at.bofh.it> |
| Organization | Red Hat GmbH |
Am 16.12.2016 um 16:10 schrieb Radim Krčmář:
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
> ---
> v2: r-b Paolo
> ---
> arch/x86/kvm/irq_comm.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/arch/x86/kvm/irq_comm.c b/arch/x86/kvm/irq_comm.c
> index 6c0191615f23..1dfeb185a1e3 100644
> --- a/arch/x86/kvm/irq_comm.c
> +++ b/arch/x86/kvm/irq_comm.c
> @@ -297,15 +297,13 @@ int kvm_set_routing_entry(struct kvm *kvm,
> case KVM_IRQ_ROUTING_IRQCHIP:
> delta = 0;
> switch (ue->u.irqchip.irqchip) {
> + case KVM_IRQCHIP_PIC_SLAVE:
> + delta = 8;
> + /* fall through */
> case KVM_IRQCHIP_PIC_MASTER:
> e->set = kvm_set_pic_irq;
> max_pin = PIC_NUM_PINS;
> break;
> - case KVM_IRQCHIP_PIC_SLAVE:
> - e->set = kvm_set_pic_irq;
> - max_pin = PIC_NUM_PINS;
> - delta = 8;
> - break;
> case KVM_IRQCHIP_IOAPIC:
> max_pin = KVM_IOAPIC_NUM_PINS;
> e->set = kvm_set_ioapic_irq;
>
Had the exact same thing in mind when reading that piece of code.
Reviewed-by: David Hildenbrand <david@redhat.com>
--
David
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/6] KVM: x86: minor irqchip improvements (API change) Radim Krčmář <rkrcmar@redhat.com> - 2016-12-16 16:20 +0100
[PATCH v2 2/6] KVM: x86: decouple irqchip_in_kernel() and pic_irqchip() Radim Krčmář <rkrcmar@redhat.com> - 2016-12-16 16:20 +0100
Re: [PATCH v2 2/6] KVM: x86: decouple irqchip_in_kernel() and pic_irqchip() Paolo Bonzini <pbonzini@redhat.com> - 2016-12-16 16:30 +0100
Re: [PATCH v2 2/6] KVM: x86: decouple irqchip_in_kernel() and pic_irqchip() Radim Krčmář <rkrcmar@redhat.com> - 2016-12-16 16:50 +0100
Re: [PATCH v2 2/6] KVM: x86: decouple irqchip_in_kernel() and pic_irqchip() David Hildenbrand <david@redhat.com> - 2017-01-03 14:00 +0100
Re: [PATCH v2 2/6] KVM: x86: decouple irqchip_in_kernel() and pic_irqchip() Peter Xu <peterx@redhat.com> - 2017-01-10 06:20 +0100
Re: [PATCH v2 2/6] KVM: x86: decouple irqchip_in_kernel() and pic_irqchip() Paolo Bonzini <pbonzini@redhat.com> - 2017-01-10 10:40 +0100
[PATCH v2 4/6] KVM: x86: refactor pic setup in kvm_set_routing_entry Radim Krčmář <rkrcmar@redhat.com> - 2016-12-16 16:20 +0100
Re: [PATCH v2 4/6] KVM: x86: refactor pic setup in kvm_set_routing_entry David Hildenbrand <david@redhat.com> - 2017-01-03 14:10 +0100
[PATCH v2 3/6] KVM: x86: make pic setup code look like ioapic setup Radim Krčmář <rkrcmar@redhat.com> - 2016-12-16 16:20 +0100
Re: [PATCH v2 3/6] KVM: x86: make pic setup code look like ioapic setup David Hildenbrand <david@redhat.com> - 2017-01-03 14:10 +0100
Re: [PATCH v2 3/6] KVM: x86: make pic setup code look like ioapic setup Paolo Bonzini <pbonzini@redhat.com> - 2017-01-03 17:20 +0100
Re: [PATCH v2 3/6] KVM: x86: make pic setup code look like ioapic setup David Hildenbrand <david@redhat.com> - 2017-01-04 10:20 +0100
[PATCH v2 5/6] KVM: x86: prevent setup of invalid routes Radim Krčmář <rkrcmar@redhat.com> - 2016-12-16 16:20 +0100
Re: [PATCH v2 5/6] KVM: x86: prevent setup of invalid routes David Hildenbrand <david@redhat.com> - 2017-01-03 14:10 +0100
Re: [PATCH v2 5/6] KVM: x86: prevent setup of invalid routes Peter Xu <peterx@redhat.com> - 2017-01-10 06:30 +0100
Re: [PATCH v2 5/6] KVM: x86: prevent setup of invalid routes Paolo Bonzini <pbonzini@redhat.com> - 2017-01-10 10:50 +0100
[PATCH v2 6/6] KVM: x86: simplify conditions with split/kernel irqchip Radim Krčmář <rkrcmar@redhat.com> - 2016-12-16 16:20 +0100
Re: [PATCH v2 6/6] KVM: x86: simplify conditions with split/kernel irqchip David Hildenbrand <david@redhat.com> - 2017-01-03 16:20 +0100
[PATCH v2 1/6] KVM: x86: don't allow kernel irqchip with split irqchip Radim Krčmář <rkrcmar@redhat.com> - 2016-12-16 16:20 +0100
Re: [PATCH v2 1/6] KVM: x86: don't allow kernel irqchip with split irqchip David Hildenbrand <david@redhat.com> - 2017-01-03 13:20 +0100
csiph-web