Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1549766
| From | Max Bires <jbires@google.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] char: lack of bool string made CONFIG_DEVPORT always on |
| Date | 2017-01-03 14:00 +0100 |
| Message-ID | <sVwR3-6u9-5@gated-at.bofh.it> (permalink) |
| References | <sO5LX-81n-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This ensured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if it's not being used. Adding a message here in order to make this user visible. Signed-off-by: Max Bires <jbires@google.com> Acked-by: Arnd Bergmann <arnd@arndb.de> --- drivers/char/Kconfig | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig index 7ad3127..e8fc493 100644 --- a/drivers/char/Kconfig +++ b/drivers/char/Kconfig @@ -589,10 +589,13 @@ config TELCLOCK controlling the behavior of this hardware. config DEVPORT - bool + bool "/dev/port character device" depends on !M68K depends on ISA || PCI default y + help + Say Y here if you want to support the /dev/port device. The + /dev/port device is similar to /dev/mem, but for I/O ports. config DCC_TTY tristate "DCC tty driver" -- 2.8.0.rc3.226.g39d4020
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] char: lack of bool string made CONFIG_DEVPORT always on Max <jbires@google.com> - 2016-12-14 01:40 +0100
Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Greg KH <gregkh@linuxfoundation.org> - 2016-12-14 02:10 +0100
[PATCH] char: lack of bool string made CONFIG_DEVPORT always on Max <jbires@google.com> - 2016-12-14 02:30 +0100
Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-14 10:10 +0100
Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Arnd Bergmann <arnd@arndb.de> - 2016-12-14 10:20 +0100
Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Josh Triplett <josh@joshtriplett.org> - 2016-12-14 11:00 +0100
Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Arnd Bergmann <arnd@arndb.de> - 2017-01-02 21:50 +0100
[PATCH] char: lack of bool string made CONFIG_DEVPORT always on Max Bires <jbires@google.com> - 2017-01-03 14:00 +0100
Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Greg KH <gregkh@linuxfoundation.org> - 2017-01-03 15:00 +0100
[PATCH] Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This esnured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if it's not being used. Adding a message here in order to make this user visible. Max Bires <jbires@google.com> - 2017-01-03 15:30 +0100
Re: [PATCH] Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This esnured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if it's not being used. Adding a message here in order to make this user visible. Greg KH <gregkh@linuxfoundation.org> - 2017-01-03 15:40 +0100
[PATCH] char: lack of bool string made CONFIG_DEVPORT always on Max Bires <jbires@google.com> - 2017-01-03 17:30 +0100
csiph-web