Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1555092
| From | Paolo Bonzini <pbonzini@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 2/6] KVM: x86: decouple irqchip_in_kernel() and pic_irqchip() |
| Date | 2017-01-10 10:40 +0100 |
| Message-ID | <sY14m-80P-25@gated-at.bofh.it> (permalink) |
| References | <sP2sF-5nI-3@gated-at.bofh.it> <sP2sG-5nI-25@gated-at.bofh.it> <sVwR3-6u9-3@gated-at.bofh.it> <sXX0K-5zU-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 10/01/2017 06:09, Peter Xu wrote:
>> Was wondering if FULL/SPLIT would be a better naming. However I also
>> find irqchip_kernel() vs irqchip_in_kernel() slightly confusing.
> Me too. Since we have kvm_irqchip_mode enum above, how about renaming
> irqchip_{kernel|split}() into irqchip_mode_{kernel|split}()?
>
> Sorry for such a late comment...
No problem, it can be done on top.
Another thing to do is to make irqchip_in_kernel check mode != NONE.
Paolo
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
Re: [PATCH v2 2/6] KVM: x86: decouple irqchip_in_kernel() and pic_irqchip() Peter Xu <peterx@redhat.com> - 2017-01-10 06:20 +0100 Re: [PATCH v2 2/6] KVM: x86: decouple irqchip_in_kernel() and pic_irqchip() Paolo Bonzini <pbonzini@redhat.com> - 2017-01-10 10:40 +0100
csiph-web