Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1551614
| From | Alim Akhtar <alim.akhtar@samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V2 1/5] Documetation: samsung-phy: add the exynos-pcie-phy binding |
| Date | 2017-01-05 05:30 +0100 |
| Message-ID | <sW7QB-68e-1@gated-at.bofh.it> (permalink) |
| References | <sVT1f-4FT-13@gated-at.bofh.it> <sVT1g-4FT-45@gated-at.bofh.it> <sVT1g-4FT-43@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Jaehoon,
On 01/04/2017 06:04 PM, Jaehoon Chung wrote:
> Adds the exynos-pcie-phy binding for Exynos PCIe PHY.
> This is for using generic PHY framework.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
> Changelog on V2:
> - Remove the child node.
> - Add 2nd address to the parent reg prop.
>
> Documentation/devicetree/bindings/phy/samsung-phy.txt | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt b/Documentation/devicetree/bindings/phy/samsung-phy.txt
> index 9872ba8..ab80bfe 100644
> --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt
> +++ b/Documentation/devicetree/bindings/phy/samsung-phy.txt
> @@ -191,3 +191,20 @@ Example:
> usbdrdphy0 = &usb3_phy0;
> usbdrdphy1 = &usb3_phy1;
> };
> +
> +Samsung Exynos SoC series PCIe PHY controller
> +--------------------------------------------------
> +Required properties:
> +- compatible : Should be set to "samsung,exynos5440-pcie-phy"
> +- #phy-cells : Must be zero
> +- reg : a register used by phy driver.
> + - First is for phy register, second is for block register.
> +- reg-names : Must be set to "phy" and "block".
> +
In general PHY uses a "reference clock" to work, if that is true for
5440 also, will you consider adding an (may be) optional clock
properties as well?
otherwise this binding looks ok to me.
> +Example:
> + pcie_phy0: pcie-phy@270000 {
> + #phy-cells = <0>;
> + compatible = "samsung,exynos5440-pcie-phy";
> + reg = <0x270000 0x1000>, <0x271000 0x40>;
> + reg-names = "phy", "block";
> + };
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V2 0/5] PCI: exynos: use the PHY generic framework Jaehoon Chung <jh80.chung@samsung.com> - 2017-01-04 13:40 +0100
[PATCH V2 5/5] ARM: dts: exynos5440: support the phy-pcie node for pcie Jaehoon Chung <jh80.chung@samsung.com> - 2017-01-04 13:40 +0100
Re: [PATCH V2 5/5] ARM: dts: exynos5440: support the phy-pcie node for pcie Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-04 19:10 +0100
Re: [PATCH V2 5/5] ARM: dts: exynos5440: support the phy-pcie node for pcie "Jingoo Han" <jingoohan1@gmail.com> - 2017-01-04 19:10 +0100
Re: [PATCH V2 5/5] ARM: dts: exynos5440: support the phy-pcie node for pcie Jaehoon Chung <jh80.chung@samsung.com> - 2017-01-05 03:30 +0100
Re: [PATCH V2 5/5] ARM: dts: exynos5440: support the phy-pcie node for pcie "pankaj.dubey" <pankaj.dubey@samsung.com> - 2017-01-05 10:10 +0100
[PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe phy Jaehoon Chung <jh80.chung@samsung.com> - 2017-01-04 13:40 +0100
Re: [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe phy Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-04 19:00 +0100
Re: [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe phy Jaehoon Chung <jh80.chung@samsung.com> - 2017-01-05 03:30 +0100
Re: [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe phy "Jingoo Han" <jingoohan1@gmail.com> - 2017-01-04 21:30 +0100
Re: [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe phy "pankaj.dubey" <pankaj.dubey@samsung.com> - 2017-01-05 07:20 +0100
Re: [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe phy Alim Akhtar <alim.akhtar@samsung.com> - 2017-01-09 14:40 +0100
Re: [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe phy Vivek Gautam <vivek.gautam@codeaurora.org> - 2017-01-10 07:10 +0100
Re: [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe phy Jaehoon Chung <jh80.chung@samsung.com> - 2017-01-10 07:20 +0100
Re: [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe phy Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-16 09:40 +0100
Re: [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe phy Jaehoon Chung <jh80.chung@samsung.com> - 2017-01-16 12:10 +0100
[PATCH V2 1/5] Documetation: samsung-phy: add the exynos-pcie-phy binding Jaehoon Chung <jh80.chung@samsung.com> - 2017-01-04 13:40 +0100
Re: [PATCH V2 1/5] Documetation: samsung-phy: add the exynos-pcie-phy binding Rob Herring <robh@kernel.org> - 2017-01-04 16:20 +0100
Re: [PATCH V2 1/5] Documetation: samsung-phy: add the exynos-pcie-phy binding Alim Akhtar <alim.akhtar@samsung.com> - 2017-01-05 05:30 +0100
Re: [PATCH V2 1/5] Documetation: samsung-phy: add the exynos-pcie-phy binding "pankaj.dubey" <pankaj.dubey@samsung.com> - 2017-01-05 07:10 +0100
[PATCH V2 4/5] PCI: exynos: support the using PHY generic framework Jaehoon Chung <jh80.chung@samsung.com> - 2017-01-04 13:40 +0100
Re: [PATCH V2 4/5] PCI: exynos: support the using PHY generic framework Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-04 19:00 +0100
Re: [PATCH V2 4/5] PCI: exynos: support the using PHY generic framework Jaehoon Chung <jh80.chung@samsung.com> - 2017-01-05 03:40 +0100
Re: [PATCH V2 4/5] PCI: exynos: support the using PHY generic framework "Jingoo Han" <jingoohan1@gmail.com> - 2017-01-04 21:00 +0100
Re: [PATCH V2 4/5] PCI: exynos: support the using PHY generic framework "pankaj.dubey" <pankaj.dubey@samsung.com> - 2017-01-05 10:10 +0100
Re: [PATCH V2 4/5] PCI: exynos: support the using PHY generic framework Alim Akhtar <alim.akhtar@samsung.com> - 2017-01-09 14:50 +0100
Re: [PATCH V2 0/5] PCI: exynos: use the PHY generic framework Bjorn Helgaas <helgaas@kernel.org> - 2017-01-12 22:10 +0100
csiph-web