Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on
Date	2016-12-14 10:20 +0100
Message-ID	<sOdTc-4EN-33@gated-at.bofh.it> (permalink)
References	<sO6eZ-8pC-7@gated-at.bofh.it> <sO6yl-8vr-1@gated-at.bofh.it> <sOdJw-4BA-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wednesday, December 14, 2016 9:58:53 AM CET Geert Uytterhoeven wrote:
> >
> > --- a/drivers/char/Kconfig
> > +++ b/drivers/char/Kconfig
> > @@ -589,10 +589,13 @@ config TELCLOCK
> >           controlling the behavior of this hardware.
> >
> >  config DEVPORT
> > -       bool
> > +       bool "/dev/port character device"
> 
> bool "/dev/port character device" if EXPERT?

I think the 'default y' is good enough, there are good reasons
even for non-EXPERT configurations to turn this off.

	Arnd

Thread

[PATCH] char: lack of bool string made CONFIG_DEVPORT always on Max <jbires@google.com> - 2016-12-14 01:40 +0100
  Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Greg KH <gregkh@linuxfoundation.org> - 2016-12-14 02:10 +0100
    [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Max <jbires@google.com> - 2016-12-14 02:30 +0100
      Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-14 10:10 +0100
        Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Arnd Bergmann <arnd@arndb.de> - 2016-12-14 10:20 +0100
          Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Josh Triplett <josh@joshtriplett.org> - 2016-12-14 11:00 +0100
            Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Arnd Bergmann <arnd@arndb.de> - 2017-01-02 21:50 +0100
  [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Max Bires <jbires@google.com> - 2017-01-03 14:00 +0100
    Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Greg KH <gregkh@linuxfoundation.org> - 2017-01-03 15:00 +0100
  [PATCH] Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This esnured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if it's not being used. Adding a message here in order to make this user visible. Max Bires <jbires@google.com> - 2017-01-03 15:30 +0100
    Re: [PATCH] Without a bool string present, using "# CONFIG_DEVPORT  is not set" in defconfig files would not actually unset devport. This  esnured that /dev/port was always on, but there are reasons a user may wish  to disable it (smaller kernel, attack surface reduction) if it's not being  used. Adding a message here in order to make this user visible. Greg KH <gregkh@linuxfoundation.org> - 2017-01-03 15:40 +0100
    [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Max Bires <jbires@google.com> - 2017-01-03 17:30 +0100

csiph-web