Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1541615 > unrolled thread

[PATCH] char: lack of bool string made CONFIG_DEVPORT always on

Started byMax <jbires@google.com>
First post2016-12-14 01:40 +0100
Last post2017-01-03 17:30 +0100
Articles 12 — 6 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Max <jbires@google.com> - 2016-12-14 01:40 +0100
    Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Greg KH <gregkh@linuxfoundation.org> - 2016-12-14 02:10 +0100
      [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Max <jbires@google.com> - 2016-12-14 02:30 +0100
        Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-14 10:10 +0100
          Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Arnd Bergmann <arnd@arndb.de> - 2016-12-14 10:20 +0100
            Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Josh Triplett <josh@joshtriplett.org> - 2016-12-14 11:00 +0100
              Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Arnd Bergmann <arnd@arndb.de> - 2017-01-02 21:50 +0100
    [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Max Bires <jbires@google.com> - 2017-01-03 14:00 +0100
      Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Greg KH <gregkh@linuxfoundation.org> - 2017-01-03 15:00 +0100
    [PATCH] Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This esnured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if it's not being used. Adding a message here in order to make this user visible. Max Bires <jbires@google.com> - 2017-01-03 15:30 +0100
      Re: [PATCH] Without a bool string present, using "# CONFIG_DEVPORT  is not set" in defconfig files would not actually unset devport. This  esnured that /dev/port was always on, but there are reasons a user may wish  to disable it (smaller kernel, attack surface reduction) if it's not being  used. Adding a message here in order to make this user visible. Greg KH <gregkh@linuxfoundation.org> - 2017-01-03 15:40 +0100
      [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Max Bires <jbires@google.com> - 2017-01-03 17:30 +0100

#1541615 — [PATCH] char: lack of bool string made CONFIG_DEVPORT always on

FromMax <jbires@google.com>
Date2016-12-14 01:40 +0100
Subject[PATCH] char: lack of bool string made CONFIG_DEVPORT always on
Message-ID<sO5LX-81n-5@gated-at.bofh.it>
From: Max Bires <jbires@google.com>

Without a bool string present, using "# CONFIG_DEVPORT is not set" in
defconfig files would not actually unset devport. This ensured that
/dev/port was always on, but there are reasons a user may wish to disable
it (smaller kernel, attack surface reduction) if it's not being used. Adding
a message here in order to make this user visible.

Signed-off-by: Max Bires <jbires@google.com>
---
 drivers/char/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index 7ad3127..d647e7e 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -589,10 +589,13 @@ config TELCLOCK
 	  controlling the behavior of this hardware.
 
 config DEVPORT
-	bool
+	bool "/dev/port character device"
 	depends on !M68K
 	depends on ISA || PCI
 	default y
+	help
+		Say Y here if you want to support the /dev/port device. The
+		/dev/port device is similar to /dev/mem, but for I/O ports.
 
 config DCC_TTY
 	tristate "DCC tty driver"
-- 
2.8.0.rc3.226.g39d4020

[toc] | [next] | [standalone]

#1541625

FromGreg KH <gregkh@linuxfoundation.org>
Date2016-12-14 02:10 +0100
Message-ID<sO6eZ-8pC-7@gated-at.bofh.it>
In reply to#1541615
On Tue, Dec 13, 2016 at 04:32:25PM -0800, Max wrote:
> From: Max Bires <jbires@google.com>
> 
> Without a bool string present, using "# CONFIG_DEVPORT is not set" in
> defconfig files would not actually unset devport. This ensured that
> /dev/port was always on, but there are reasons a user may wish to disable
> it (smaller kernel, attack surface reduction) if it's not being used. Adding
> a message here in order to make this user visible.
> 
> Signed-off-by: Max Bires <jbires@google.com>
> ---
>  drivers/char/Kconfig | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index 7ad3127..d647e7e 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -589,10 +589,13 @@ config TELCLOCK
>  	  controlling the behavior of this hardware.
>  
>  config DEVPORT
> -	bool
> +	bool "/dev/port character device"
>  	depends on !M68K
>  	depends on ISA || PCI
>  	default y
> +	help
> +		Say Y here if you want to support the /dev/port device. The
> +		/dev/port device is similar to /dev/mem, but for I/O ports.


Hm, did you look at how the indentation for all of the help entries are
in this file?  Please match it up to be the same...

Other than that, this looks much better, the format and style of the
submission was fine.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1541628

FromMax <jbires@google.com>
Date2016-12-14 02:30 +0100
Message-ID<sO6yl-8vr-1@gated-at.bofh.it>
In reply to#1541625
Without a bool string present, using "# CONFIG_DEVPORT is not set" in
defconfig files would not actually unset devport. This ensured that
/dev/port was always on, but there are reasons a user may wish to disable
it (smaller kernel, attack surface reduction) if it's not being used. Adding
a message here in order to make this user visible.

Signed-off-by: Max Bires <jbires@google.com>
---
 drivers/char/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index 7ad3127..e8fc493 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -589,10 +589,13 @@ config TELCLOCK
 	  controlling the behavior of this hardware.
 
 config DEVPORT
-	bool
+	bool "/dev/port character device"
 	depends on !M68K
 	depends on ISA || PCI
 	default y
+	help
+	  Say Y here if you want to support the /dev/port device. The
+	  /dev/port device is similar to /dev/mem, but for I/O ports.
 
 config DCC_TTY
 	tristate "DCC tty driver"
-- 
2.8.0.rc3.226.g39d4020

[toc] | [prev] | [next] | [standalone]

#1541773

FromGeert Uytterhoeven <geert@linux-m68k.org>
Date2016-12-14 10:10 +0100
Message-ID<sOdJw-4BA-21@gated-at.bofh.it>
In reply to#1541628
On Wed, Dec 14, 2016 at 2:18 AM, Max <jbires@google.com> wrote:
> Without a bool string present, using "# CONFIG_DEVPORT is not set" in
> defconfig files would not actually unset devport. This ensured that
> /dev/port was always on, but there are reasons a user may wish to disable
> it (smaller kernel, attack surface reduction) if it's not being used. Adding
> a message here in order to make this user visible.
>
> Signed-off-by: Max Bires <jbires@google.com>
> ---
>  drivers/char/Kconfig | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index 7ad3127..e8fc493 100644
>
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -589,10 +589,13 @@ config TELCLOCK
>           controlling the behavior of this hardware.
>
>  config DEVPORT
> -       bool
> +       bool "/dev/port character device"

bool "/dev/port character device" if EXPERT?

>         depends on !M68K
>         depends on ISA || PCI
>         default y
> +       help
> +         Say Y here if you want to support the /dev/port device. The
> +         /dev/port device is similar to /dev/mem, but for I/O ports.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[toc] | [prev] | [next] | [standalone]

#1541786

FromArnd Bergmann <arnd@arndb.de>
Date2016-12-14 10:20 +0100
Message-ID<sOdTc-4EN-33@gated-at.bofh.it>
In reply to#1541773
On Wednesday, December 14, 2016 9:58:53 AM CET Geert Uytterhoeven wrote:
> >
> > --- a/drivers/char/Kconfig
> > +++ b/drivers/char/Kconfig
> > @@ -589,10 +589,13 @@ config TELCLOCK
> >           controlling the behavior of this hardware.
> >
> >  config DEVPORT
> > -       bool
> > +       bool "/dev/port character device"
> 
> bool "/dev/port character device" if EXPERT?

I think the 'default y' is good enough, there are good reasons
even for non-EXPERT configurations to turn this off.

	Arnd

[toc] | [prev] | [next] | [standalone]

#1541801

FromJosh Triplett <josh@joshtriplett.org>
Date2016-12-14 11:00 +0100
Message-ID<sOevU-4RP-33@gated-at.bofh.it>
In reply to#1541786
On Wed, Dec 14, 2016 at 10:11:19AM +0100, Arnd Bergmann wrote:
> On Wednesday, December 14, 2016 9:58:53 AM CET Geert Uytterhoeven wrote:
> > >
> > > --- a/drivers/char/Kconfig
> > > +++ b/drivers/char/Kconfig
> > > @@ -589,10 +589,13 @@ config TELCLOCK
> > >           controlling the behavior of this hardware.
> > >
> > >  config DEVPORT
> > > -       bool
> > > +       bool "/dev/port character device"
> > 
> > bool "/dev/port character device" if EXPERT?
> 
> I think the 'default y' is good enough, there are good reasons
> even for non-EXPERT configurations to turn this off.

Agreed. /dev/port seems like something the majority of modern systems
can safely turn off.

[toc] | [prev] | [next] | [standalone]

#1549390

FromArnd Bergmann <arnd@arndb.de>
Date2017-01-02 21:50 +0100
Message-ID<sVhIm-40h-13@gated-at.bofh.it>
In reply to#1541801
On Tuesday, December 27, 2016 3:05:54 PM CET Max Bires wrote:
> So this is fine as is then? Just making sure that outside of the
> development tree being closed for now that this patch is good to go now
> that space/tab formatting is fixed.

Yes, the change is fine, please add my

Acked-by: Arnd Bergmann <arnd@arndb.de>

Note two details:

- Please avoid top-posting in emails as you did here

- In your patch submission the sender is listed as "Max" without
  a last name, while your Signed-off-by line contains your full
  name. As the sender gets used as the author tag, please
  resubmit the patch with your full name as sender or add a
  separate "From: " line at the beginning of the mail.
  Git format-patch/send-email gets this right as long as your
  git configuration has your full name.

	Arnd

[toc] | [prev] | [next] | [standalone]

#1549766

FromMax Bires <jbires@google.com>
Date2017-01-03 14:00 +0100
Message-ID<sVwR3-6u9-5@gated-at.bofh.it>
In reply to#1541615
Without a bool string present, using "# CONFIG_DEVPORT is not set" in
defconfig files would not actually unset devport. This ensured that
/dev/port was always on, but there are reasons a user may wish to disable
it (smaller kernel, attack surface reduction) if it's not being used. Adding
a message here in order to make this user visible.

Signed-off-by: Max Bires <jbires@google.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/char/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index 7ad3127..e8fc493 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -589,10 +589,13 @@ config TELCLOCK
 	  controlling the behavior of this hardware.
 
 config DEVPORT
-	bool
+	bool "/dev/port character device"
 	depends on !M68K
 	depends on ISA || PCI
 	default y
+	help
+	  Say Y here if you want to support the /dev/port device. The
+	  /dev/port device is similar to /dev/mem, but for I/O ports.
 
 config DCC_TTY
 	tristate "DCC tty driver"
-- 
2.8.0.rc3.226.g39d4020

[toc] | [prev] | [next] | [standalone]

#1549787

FromGreg KH <gregkh@linuxfoundation.org>
Date2017-01-03 15:00 +0100
Message-ID<sVxN8-78b-9@gated-at.bofh.it>
In reply to#1549766
On Tue, Jan 03, 2017 at 04:53:13AM -0800, Max Bires wrote:
> Without a bool string present, using "# CONFIG_DEVPORT is not set" in
> defconfig files would not actually unset devport. This ensured that
> /dev/port was always on, but there are reasons a user may wish to disable
> it (smaller kernel, attack surface reduction) if it's not being used. Adding
> a message here in order to make this user visible.
> 
> Signed-off-by: Max Bires <jbires@google.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/char/Kconfig | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index 7ad3127..e8fc493 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -589,10 +589,13 @@ config TELCLOCK
>  	  controlling the behavior of this hardware.
>  
>  config DEVPORT
> -	bool
> +	bool "/dev/port character device"
>  	depends on !M68K
>  	depends on ISA || PCI
>  	default y
> +	help
> +	  Say Y here if you want to support the /dev/port device. The
> +	  /dev/port device is similar to /dev/mem, but for I/O ports.
>  
>  config DCC_TTY
>  	tristate "DCC tty driver"

This does not apply at all to 4.10-rc2, what did you make it against?
Please redo it so that I can actually apply it...

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1549807 — [PATCH] Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This esnured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if it's not being used. Adding a message here in order to make this user visible.

FromMax Bires <jbires@google.com>
Date2017-01-03 15:30 +0100
Subject[PATCH] Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This esnured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if it's not being used. Adding a message here in order to make this user visible.
Message-ID<sVyga-7AS-13@gated-at.bofh.it>
In reply to#1541615
Signed-off-by: Max Bires <jbires@google.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/char/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index fde005e..4ee2a10 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -571,9 +571,12 @@ config TELCLOCK
 	  controlling the behavior of this hardware.
 
 config DEVPORT
-	bool
+	bool "/dev/port character device"
 	depends on ISA || PCI
 	default y
+	help
+	  Say Y here if you want to support the /dev/port device. The /dev/port
+	  device is similar to /dev/mem, but for I/O ports.
 
 source "drivers/s390/char/Kconfig"
 
-- 
2.8.0.rc3.226.g39d4020

[toc] | [prev] | [next] | [standalone]

#1549822 — Re: [PATCH] Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This esnured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if it's not being used. Adding a message here in order to make this user visible.

FromGreg KH <gregkh@linuxfoundation.org>
Date2017-01-03 15:40 +0100
SubjectRe: [PATCH] Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This esnured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if it's not being used. Adding a message here in order to make this user visible.
Message-ID<sVypQ-7EJ-45@gated-at.bofh.it>
In reply to#1549807
On Tue, Jan 03, 2017 at 06:26:33AM -0800, Max Bires wrote:
> Signed-off-by: Max Bires <jbires@google.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/char/Kconfig | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Odd subject line :(

[toc] | [prev] | [next] | [standalone]

#1549929

FromMax Bires <jbires@google.com>
Date2017-01-03 17:30 +0100
Message-ID<sVA8i-ua-11@gated-at.bofh.it>
In reply to#1549807
Without a bool string present, using "# CONFIG_DEVPORT is not set" in
defconfig files would not actually unset devport. This esnured that
/dev/port was always on, but there are reasons a user may wish to
disable it (smaller kernel, attack surface reduction) if it's not being
used. Adding a message here in order to make this user visible.

Signed-off-by: Max Bires <jbires@google.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/char/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index fde005e..4ee2a10 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -571,9 +571,12 @@ config TELCLOCK
 	  controlling the behavior of this hardware.
 
 config DEVPORT
-	bool
+	bool "/dev/port character device"
 	depends on ISA || PCI
 	default y
+	help
+	  Say Y here if you want to support the /dev/port device. The /dev/port
+	  device is similar to /dev/mem, but for I/O ports.
 
 source "drivers/s390/char/Kconfig"
 
-- 
2.8.0.rc3.226.g39d4020

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web