Re: [PATCH 12/23] drm: omapdrm: plane: update fifo size on atomic update

From	Tomi Valkeinen <tomi.valkeinen@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 12/23] drm: omapdrm: plane: update fifo size on atomic update
Date	2016-12-14 10:20 +0100
Message-ID	<sOdTc-4EN-25@gated-at.bofh.it> (permalink)
References	<rat9g-3s9-15@gated-at.bofh.it> <sNZdw-41E-23@gated-at.bofh.it> <sOdq9-4fU-5@gated-at.bofh.it> <sOdJw-4BA-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 14/12/16 11:10, Laurent Pinchart wrote:
> Hi Tomi,
> 
> On Wednesday 14 Dec 2016 10:43:18 Tomi Valkeinen wrote:
>> On 13/12/16 19:35, Laurent Pinchart wrote:
>>> On Tuesday 08 Mar 2016 17:39:44 Sebastian Reichel wrote:
>>>> This is a workaround for a hardware bug occuring
>>>> on OMAP3 with manually updated panels.
>>>
>>> Could you please explain what the bug is and how the workaround operates ?
>>> Do you have a reference to an errata document ?
>>
>> I don't think I ever found out exactly why the problem happens. But on
>> OMAP3 DSI, the fifo thresholds had to be tuned slightly, otherwise DISPC
>> would stop. dispc_ovl_compute_fifo_thresholds() does that tuning if
>> "manual_update" parameter is set on OMAP3.
> 
> I've had a look at dispc_ovl_compute_fifo_thresholds() and the patch makes 
> sense to me. If Sebastian could address the small issues I pointed out, we 
> could then merge this. Alternatively I can take care of addressing them.

It's only needed with the rest of the DSI manual update series, so I'd
rather keep it as part of that series.

 Tomi

Thread

Re: [PATCH 12/23] drm: omapdrm: plane: update fifo size on atomic update Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-12-13 18:40 +0100
  Re: [PATCH 12/23] drm: omapdrm: plane: update fifo size on atomic  update Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-12-14 09:50 +0100
    Re: [PATCH 12/23] drm: omapdrm: plane: update fifo size on atomic update Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-12-14 10:10 +0100
      Re: [PATCH 12/23] drm: omapdrm: plane: update fifo size on atomic  update Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-12-14 10:20 +0100
        Re: [PATCH 12/23] drm: omapdrm: plane: update fifo size on atomic  update Sebastian Reichel <sre@kernel.org> - 2016-12-14 15:10 +0100
          Re: [PATCH 12/23] drm: omapdrm: plane: update fifo size on atomic update Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-12-14 22:40 +0100
            Re: [PATCH 12/23] drm: omapdrm: plane: update fifo size on atomic  update Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-12-15 09:50 +0100

csiph-web