Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1466220

[PATCH 3/4] cpuidle/menu: stop seeking deeper idle if current state is too deep

Show all headers | View raw

The obsolete commit 71abbbf85 want to introduce a dynamic cstates,
but it was removed for long time. Just left the nonsense deeper cstate
checking.

Since all target_residency and exit_latency are going longer in deeper
idle state, no needs to waste some cpu cycle on useless seeking.

Signed-off-by: Alex Shi <alex.shi@linaro.org>
To: linux-kernel@vger.kernel.org
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Alex Shi <alex.shi@linaro.org>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: Rik van Riel <riel@redhat.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
---
 drivers/cpuidle/governors/menu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c
index 03d38c2..bb58e2a 100644
--- a/drivers/cpuidle/governors/menu.c
+++ b/drivers/cpuidle/governors/menu.c
@@ -358,9 +358,9 @@ static int menu_select(struct cpuidle_driver *drv, struct cpuidle_device *dev)
 		if (s->disabled || su->disable)
 			continue;
 		if (s->target_residency > data->predicted_us)
-			continue;
+			break;
 		if (s->exit_latency > latency_req)
-			continue;
+			break;
 
 		data->last_state_idx = i;
 	}
-- 
2.8.1.101.g72d917a

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] cpu: clean up register_cpu func Alex Shi <alex.shi@linaro.org> - 2016-08-19 10:30 +0200
  [PATCH 2/4] cpu: expose pm_qos_resume_latency for each cpu Alex Shi <alex.shi@linaro.org> - 2016-08-19 10:30 +0200
    Re: [PATCH 2/4] cpu: expose pm_qos_resume_latency for each cpu Alex Shi <alex.shi@linaro.org> - 2016-08-22 06:50 +0200
  [PATCH 4/4] cpuidle/menu: add per cpu pm_qos_resume_latency consideration Alex Shi <alex.shi@linaro.org> - 2016-08-19 10:30 +0200
  [PATCH 3/4] cpuidle/menu: stop seeking deeper idle if current state is too deep Alex Shi <alex.shi@linaro.org> - 2016-08-19 10:30 +0200
  Re: [PATCH 1/4] cpu: clean up register_cpu func Alex Shi <alex.shi@linaro.org> - 2016-08-22 05:30 +0200
  Re: [PATCH 1/4] cpu: clean up register_cpu func Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-08-22 19:00 +0200

csiph-web