Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1467324
| From | Alex Shi <alex.shi@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/4] cpu: clean up register_cpu func |
| Date | 2016-08-22 05:30 +0200 |
| Message-ID | <s8O5X-Lh-7@gated-at.bofh.it> (permalink) |
| References | <s7NlD-3dZ-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Is there any comments for this patch series? Thanks! On 08/19/2016 04:25 PM, Alex Shi wrote: > This patch could reduce one branch in this function. Also > make the code more readble. > > Signed-off-by: Alex Shi <alex.shi@linaro.org> > To: linux-kernel@vger.kernel.org > To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > drivers/base/cpu.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c > index 691eeea..4c28e1a 100644 > --- a/drivers/base/cpu.c > +++ b/drivers/base/cpu.c > @@ -371,12 +371,13 @@ int register_cpu(struct cpu *cpu, int num) > if (cpu->hotpluggable) > cpu->dev.groups = hotplugable_cpu_attr_groups; > error = device_register(&cpu->dev); > - if (!error) > - per_cpu(cpu_sys_devices, num) = &cpu->dev; > - if (!error) > - register_cpu_under_node(num, cpu_to_node(num)); > + if (error) > + return error; > > - return error; > + per_cpu(cpu_sys_devices, num) = &cpu->dev; > + register_cpu_under_node(num, cpu_to_node(num)); > + > + return 0; > } > > struct device *get_cpu_device(unsigned cpu) >
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/4] cpu: clean up register_cpu func Alex Shi <alex.shi@linaro.org> - 2016-08-19 10:30 +0200
[PATCH 2/4] cpu: expose pm_qos_resume_latency for each cpu Alex Shi <alex.shi@linaro.org> - 2016-08-19 10:30 +0200
Re: [PATCH 2/4] cpu: expose pm_qos_resume_latency for each cpu Alex Shi <alex.shi@linaro.org> - 2016-08-22 06:50 +0200
[PATCH 4/4] cpuidle/menu: add per cpu pm_qos_resume_latency consideration Alex Shi <alex.shi@linaro.org> - 2016-08-19 10:30 +0200
[PATCH 3/4] cpuidle/menu: stop seeking deeper idle if current state is too deep Alex Shi <alex.shi@linaro.org> - 2016-08-19 10:30 +0200
Re: [PATCH 1/4] cpu: clean up register_cpu func Alex Shi <alex.shi@linaro.org> - 2016-08-22 05:30 +0200
Re: [PATCH 1/4] cpu: clean up register_cpu func Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-08-22 19:00 +0200
csiph-web