Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1467365

Re: [PATCH 2/4] cpu: expose pm_qos_resume_latency for each cpu

Show all headers | View raw

Add a pr_debug for failure output.


From dc5111ed3974f994a9f1d88fdd8dc813359a3b6c Mon Sep 17 00:00:00 2001
From: Alex Shi <alex.shi@linaro.org>
Date: Tue, 16 Aug 2016 15:29:01 +0800
Subject: [PATCH 2/4] cpu: expose pm_qos_resume_latency for each cpu

The cpu-dma PM QoS constraint impacts all the cpus in the system. There
is no way to let the user to choose a PM QoS constraint per cpu.

The following patch exposes to the userspace a per cpu based sysfs file
in order to let the userspace to change the value of the PM QoS latency
constraint.

This change is inoperative in its form and the cpuidle governors have to
take into account the per cpu latency constraint in addition to the
global cpu-dma latency constraint in order to operate properly.

BTW
The pm_qos_resume_latency usage defined in
Documentation/ABI/testing/sysfs-devices-power
The /sys/devices/.../power/pm_qos_resume_latency_us attribute
contains the PM QoS resume latency limit for the given device,
which is the maximum allowed time it can take to resume the
device, after it has been suspended at run time, from a resume
request to the moment the device will be ready to process I/O,
in microseconds.  If it is equal to 0, however, this means that
the PM QoS resume latency may be arbitrary.

Signed-off-by: Alex Shi <alex.shi@linaro.org>
---
 drivers/base/cpu.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c
index 4c28e1a..ba11e23 100644
--- a/drivers/base/cpu.c
+++ b/drivers/base/cpu.c
@@ -17,6 +17,7 @@
 #include <linux/of.h>
 #include <linux/cpufeature.h>
 #include <linux/tick.h>
+#include <linux/pm_qos.h>
 
 #include "base.h"
 
@@ -376,6 +377,8 @@ int register_cpu(struct cpu *cpu, int num)
 
 	per_cpu(cpu_sys_devices, num) = &cpu->dev;
 	register_cpu_under_node(num, cpu_to_node(num));
+	if (dev_pm_qos_expose_latency_limit(&cpu->dev, 0))
+		pr_debug("CPU%d: add resume latency failed\n", num);
 
 	return 0;
 }
-- 
2.8.1.101.g72d917a

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] cpu: clean up register_cpu func Alex Shi <alex.shi@linaro.org> - 2016-08-19 10:30 +0200
  [PATCH 2/4] cpu: expose pm_qos_resume_latency for each cpu Alex Shi <alex.shi@linaro.org> - 2016-08-19 10:30 +0200
    Re: [PATCH 2/4] cpu: expose pm_qos_resume_latency for each cpu Alex Shi <alex.shi@linaro.org> - 2016-08-22 06:50 +0200
  [PATCH 4/4] cpuidle/menu: add per cpu pm_qos_resume_latency consideration Alex Shi <alex.shi@linaro.org> - 2016-08-19 10:30 +0200
  [PATCH 3/4] cpuidle/menu: stop seeking deeper idle if current state is too deep Alex Shi <alex.shi@linaro.org> - 2016-08-19 10:30 +0200
  Re: [PATCH 1/4] cpu: clean up register_cpu func Alex Shi <alex.shi@linaro.org> - 2016-08-22 05:30 +0200
  Re: [PATCH 1/4] cpu: clean up register_cpu func Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-08-22 19:00 +0200

csiph-web