Re: [PATCH v7 1/4] mfd: RK808: Add RK818 support

From	Lee Jones <lee.jones@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 1/4] mfd: RK808: Add RK818 support
Date	2016-08-19 10:40 +0200
Message-ID	<s7Nvj-3hy-7@gated-at.bofh.it> (permalink)
References	<s4GA3-f8-61@gated-at.bofh.it> <s4HPt-16w-35@gated-at.bofh.it> <s7wNR-16E-75@gated-at.bofh.it> <s7LjQ-1WI-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 19 Aug 2016, Wadim Egorov wrote:
> On 18.08.2016 16:34, Lee Jones wrote:
> > On Wed, 10 Aug 2016, Wadim Egorov wrote:
> >
> >> The RK818 chip is a Power Management IC (PMIC) for multimedia and handheld
> >> devices. It contains the following components:
> >>
> >> - Regulators
> >> - RTC
> >> - Clocking
> >> - Battery support
> >>
> >> Both RK808 and RK818 chips are using a similar register map,
> >> so we can reuse the RTC and Clocking functionality.
> >>
> >> Signed-off-by: Wadim Egorov <w.egorov@phytec.de>
> >> Tested-by: Andy Yan <andy.yan@rock-chips.com>
> >> ---
> >> Changes since v6:
> >> - Squashed in the patch
> >>   mfd: RK808: Fetch PMIC variant from chip id register
> >>
> >> ---
> >>  drivers/mfd/Kconfig       |   4 +-
> >>  drivers/mfd/rk808.c       | 226 +++++++++++++++++++++++++++++++++++++++-------
> >>  include/linux/mfd/rk808.h | 154 +++++++++++++++++++++++++++++--
> >>  3 files changed, 342 insertions(+), 42 deletions(-)

[...]

> >>  struct rk808_reg_data {
> >>  	int addr;
> >> @@ -57,6 +62,14 @@ static bool rk808_is_volatile_reg(struct device *dev, unsigned int reg)
> >>  	return false;
> >>  }
> >>  
> >> +static const struct regmap_config rk818_regmap_config = {
> >> +	.reg_bits = 8,
> >> +	.val_bits = 8,
> >> +	.max_register = RK818_USB_CTRL_REG,
> >> +	.cache_type = REGCACHE_RBTREE,
> >> +	.volatile_reg = rk808_is_volatile_reg,
> >> +};
> >> +
> >>  static const struct regmap_config rk808_regmap_config = {
> >>  	.reg_bits = 8,
> >>  	.val_bits = 8,
> >> @@ -79,11 +92,21 @@ static const struct mfd_cell rk808s[] = {
> >>  	{
> >>  		.name = "rk808-rtc",
> >>  		.num_resources = ARRAY_SIZE(rtc_resources),
> >> -		.resources = &rtc_resources[0],
> >> +		.resources = rtc_resources,
> > ?
> 
> you told me to change this

It's an unrelated change that has nothing to do with this patch, which
is why I am confused.

But it's okay, I'll let it sneak in on this occasion, rather than
asking you to send a separate patch.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v7 1/4] mfd: RK808: Add RK818 support Lee Jones <lee.jones@linaro.org> - 2016-08-18 16:50 +0200
  Re: [PATCH v7 1/4] mfd: RK808: Add RK818 support Wadim Egorov <w.egorov@phytec.de> - 2016-08-19 08:20 +0200
    Re: [PATCH v7 1/4] mfd: RK808: Add RK818 support Lee Jones <lee.jones@linaro.org> - 2016-08-19 10:40 +0200

csiph-web