Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1462719

Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler

From Tomasz Figa <tomasz.figa@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler
Date 2016-08-15 13:40 +0200
Message-ID <s6opk-4ZP-13@gated-at.bofh.it> (permalink)
References <s6n9T-4ig-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi,

2016-08-15 19:17 GMT+09:00 perr <strongbox8@zoho.com>:
> Because chained_irq_enter() has already called chip->irq_mask() and
> chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(),
> so it's not necessary to call chip->irq_*() here.
>
> Signed-off-by: perr <strongbox8@zoho.com>
>
> ---
>  drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>

Indeed, nice finding. Thanks!

Acked-by: Tomasz Figa <tomasz.figa@gmail.com>

Best regards,
Tomasz

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] pinctrl: exynos: remove duplicate calls in irq handler perr <strongbox8@zoho.com> - 2016-08-15 12:20 +0200
  Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler Tomasz Figa <tomasz.figa@gmail.com> - 2016-08-15 13:40 +0200
  Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-08-15 19:00 +0200
    Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler perr perr <strongbox8@zoho.com> - 2016-08-16 02:00 +0200
      Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-08-16 08:10 +0200

csiph-web