RE: Re: [V4 PATCH 2/2] mips/panic: Replace smp_send_stop() with kdump friendly version in panic path

From	河合英宏 / KAWAI，HIDEHIRO <hidehiro.kawai.ez@hitachi.com>
Newsgroups	linux.kernel
Subject	RE: Re: [V4 PATCH 2/2] mips/panic: Replace smp_send_stop() with kdump friendly version in panic path
Date	2016-08-15 13:40 +0200
Message-ID	<s6opk-4ZP-17@gated-at.bofh.it> (permalink)
References	<s4H34-I0-37@gated-at.bofh.it> <s4HPt-16w-37@gated-at.bofh.it> <s5baO-4C5-19@gated-at.bofh.it> <s5la9-2oe-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Corey,

> From: Corey Minyard [mailto:cminyard@mvista.com]
> Sent: Friday, August 12, 2016 10:56 PM
> I'll try to test this, but I have one comment inline...

Thank you very much!

> On 08/11/2016 10:17 PM, Dave Young wrote:
> > On 08/10/16 at 05:09pm, Hidehiro Kawai wrote:
[snip]
> >> diff --git a/arch/mips/kernel/crash.c b/arch/mips/kernel/crash.c
> >> index 610f0f3..1723b17 100644
> >> --- a/arch/mips/kernel/crash.c
> >> +++ b/arch/mips/kernel/crash.c
> >> @@ -47,9 +47,14 @@ static void crash_shutdown_secondary(void *passed_regs)
> >>
> >>   static void crash_kexec_prepare_cpus(void)
> >>   {
> >> +	static int cpus_stopped;
> >>   	unsigned int msecs;
> >> +	unsigned int ncpus;
> >>
> >> -	unsigned int ncpus = num_online_cpus() - 1;/* Excluding the panic cpu */
> >> +	if (cpus_stopped)
> >> +		return;
> 
> Wouldn't you want an atomic operation and some special handling here to
> ensure that only one CPU does this?  So if a CPU comes in here and
> another CPU is already in the process stopping the CPUs it won't result in a
> deadlock.

Because this function can be called only one panicking CPU,
there is no problem.

There are two paths which crash_kexec_prepare_cpus is called.

Path 1 (panic path):
panic()
  crash_smp_send_stop()
    crash_kexec_prepare_cpus()

Path 2 (oops path):
crash_kexec()
  __crash_kexec()
    machine_crash_shutdown()
      default_machine_crash_shutdown() // for MIPS
        crash_kexec_prepare_cpus()

Here, panic() and crash_kexec() run exclusively via
panic_cpu atomic variable.  So we can use cpus_stopped as
normal variable.

Best regards,

Hidehiro Kawai

Thread

Re: [V4 PATCH 2/2] mips/panic: Replace smp_send_stop() with kdump  friendly version in panic path Dave Young <dyoung@redhat.com> - 2016-08-12 05:20 +0200
  Re: [V4 PATCH 2/2] mips/panic: Replace smp_send_stop() with kdump  friendly version in panic path Corey Minyard <cminyard@mvista.com> - 2016-08-12 16:00 +0200
    RE: Re: [V4 PATCH 2/2] mips/panic: Replace smp_send_stop() with  kdump friendly version in panic path 河合英宏 / KAWAI，HIDEHIRO   <hidehiro.kawai.ez@hitachi.com> - 2016-08-15 13:40 +0200
      Re: [V4 PATCH 2/2] mips/panic: Replace smp_send_stop() with kdump  friendly version in panic path Corey Minyard <cminyard@mvista.com> - 2016-08-15 19:10 +0200
        Re: [V4 PATCH 2/2] mips/panic: Replace smp_send_stop() with kdump  friendly version in panic path Corey Minyard <cminyard@mvista.com> - 2016-08-15 20:10 +0200
          RE: [V4 PATCH 2/2] mips/panic: Replace smp_send_stop() with kdump  friendly version in panic path 河合英宏 / KAWAI，HIDEHIRO   <hidehiro.kawai.ez@hitachi.com> - 2016-08-16 12:40 +0200

csiph-web