Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1462992

Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler

Show all headers | View raw

On Mon, Aug 15, 2016 at 06:17:07PM +0800, perr wrote:
> Because chained_irq_enter() has already called chip->irq_mask() and
> chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(),
> so it's not necessary to call chip->irq_*() here.
> 
> Signed-off-by: perr <strongbox8@zoho.com>
> 
> ---
>  drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>


Looks correct so for the patch itself:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

However, your name "Perr" confuses me a little bit. For the
Signed-off-by statement, as mentioned in
Documentation/SubmittingPatches, a real name is required. The name
should match the author.

Would you be so kind as to use a full, real name? Unless Perr is your
full, real name... then sorry for the trouble.

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: exynos: remove duplicate calls in irq handler perr <strongbox8@zoho.com> - 2016-08-15 12:20 +0200
  Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler Tomasz Figa <tomasz.figa@gmail.com> - 2016-08-15 13:40 +0200
  Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-08-15 19:00 +0200
    Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler perr perr <strongbox8@zoho.com> - 2016-08-16 02:00 +0200
      Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-08-16 08:10 +0200

csiph-web