Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1462718

Re: [PATCH] backlight-tosa: Delete owner assignment

From Vegard Nossum <vegard.nossum@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] backlight-tosa: Delete owner assignment
Date 2016-08-15 13:40 +0200
Message-ID <s6opk-4ZP-11@gated-at.bofh.it> (permalink)
References <s6o5Y-4S0-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 15 August 2016 at 13:12, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 15 Aug 2016 13:03:29 +0200
>
> The field "owner" is set by core. Thus delete an extra initialisation.

Hi,

Just a small nit on the patch title: "delete owner assignment" is
virtually useless as a title because it has no meaning without the
broader context and only describes the literal change. It's like
naming a patch "add a line" or "change the code"; it serves no
purpose.

How about "backlight-tosa: delete _unnecessary_ assignment"? This
immediately communicates the reason for/intent of the patch (there is
unnecessary code, thus we can simplify it).

(Sorry about singling out this patch and the apparent bikeshedding,
this comment obviously applies to a lot of patches by a lot of
authors!)

Thanks,


Vegard

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] backlight-tosa: Delete owner assignment SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-15 13:20 +0200
  Re: [PATCH] backlight-tosa: Delete owner assignment Vegard Nossum <vegard.nossum@gmail.com> - 2016-08-15 13:40 +0200
    Re: backlight-tosa: Delete owner assignment SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-15 15:30 +0200
      Re: backlight-tosa: Delete owner assignment Vegard Nossum <vegard.nossum@gmail.com> - 2016-08-15 15:40 +0200
    Re: [PATCH] backlight-tosa: Delete owner assignment Lee Jones <lee.jones@linaro.org> - 2016-08-15 15:50 +0200
    [PATCH v2] backlight-tosa: Delete unnecessary assignment for the  field "owner" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-16 17:20 +0200
      Re: [PATCH v2] backlight-tosa: Delete unnecessary assignment for the  field "owner" Lee Jones <lee.jones@linaro.org> - 2016-08-17 11:50 +0200

csiph-web