Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1453309
| From | Josh Poimboeuf <jpoimboe@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues |
| Date | 2016-08-01 18:40 +0200 |
| Message-ID | <s1opY-ih-45@gated-at.bofh.it> (permalink) |
| References | <rXtHz-4Eb-5@gated-at.bofh.it> <rXtHA-4Eb-13@gated-at.bofh.it> <s0oV4-2yr-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jul 29, 2016 at 06:55:21PM -0400, Steven Rostedt wrote:
> > @@ -108,18 +97,23 @@ print_context_stack(struct task_struct *task,
> > stack = (unsigned long *)task_stack_page(task);
> >
> > while (valid_stack_ptr(task, stack, sizeof(*stack), end)) {
> > - unsigned long addr;
> > + unsigned long addr = *stack;
> >
> > addr = *stack;
> > if (__kernel_text_address(addr)) {
> > + int reliable = 0;
> > + unsigned long real_addr;
> > +
> > if ((unsigned long) stack == bp + sizeof(long)) {
> > - ops->address(data, addr, 1);
> > + reliable = 1;
> > frame = frame->next_frame;
> > bp = (unsigned long) frame;
> > - } else {
> > - ops->address(data, addr, 0);
> > }
> > - print_ftrace_graph_addr(addr, data, ops, task, graph);
> > +
> > + real_addr = ftrace_graph_ret_addr(task, graph, addr);
> > + if (addr != real_addr)
> > + ops->address(data, addr, 0);
> > + ops->address(data, real_addr, reliable);
>
> Note this changes behavior, as the original code had the ret_to_handler
> first. This makes it second. (I fixed this below).
Hm, as far as I can tell this actually keeps the original behavior. The
"unreliable" ret_to_handler is still printed first, no?
--
Josh
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Steven Rostedt <rostedt@goodmis.org> - 2016-07-30 01:00 +0200
Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-07-30 03:00 +0200
Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Steven Rostedt <rostedt@goodmis.org> - 2016-07-30 04:30 +0200
Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-07-30 16:00 +0200
Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Steven Rostedt <rostedt@goodmis.org> - 2016-08-01 16:30 +0200
Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-01 17:40 +0200
Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-02 23:10 +0200
Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Steven Rostedt <rostedt@goodmis.org> - 2016-08-02 23:20 +0200
Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-03 00:20 +0200
Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Steven Rostedt <rostedt@goodmis.org> - 2016-08-03 01:20 +0200
Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-03 04:10 +0200
Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Steven Rostedt <rostedt@goodmis.org> - 2016-08-03 04:40 +0200
Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-03 05:00 +0200
Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Steven Rostedt <rostedt@goodmis.org> - 2016-08-03 05:10 +0200
Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-03 05:20 +0200
Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Steven Rostedt <rostedt@goodmis.org> - 2016-08-03 05:30 +0200
Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-03 05:40 +0200
Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Steven Rostedt <rostedt@goodmis.org> - 2016-08-03 05:50 +0200
Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-03 16:30 +0200
Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Steven Rostedt <rostedt@goodmis.org> - 2016-08-03 05:40 +0200
Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-03 05:40 +0200
Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-01 18:20 +0200
Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Steven Rostedt <rostedt@goodmis.org> - 2016-08-01 18:20 +0200
Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-01 18:40 +0200
Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Steven Rostedt <rostedt@goodmis.org> - 2016-08-01 19:00 +0200
Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-01 18:50 +0200
csiph-web