Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1455610

Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues

From Josh Poimboeuf <jpoimboe@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues
Date 2016-08-03 05:40 +0200
Message-ID <s1Vce-5jd-7@gated-at.bofh.it> (permalink)
References (5 earlier) <s1Uzv-4PA-7@gated-at.bofh.it> <s1UJb-57K-1@gated-at.bofh.it> <s1USR-5bn-9@gated-at.bofh.it> <s1V2x-5eP-3@gated-at.bofh.it> <s1V2x-5eP-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, Aug 02, 2016 at 11:21:04PM -0400, Steven Rostedt wrote:
> On Tue, 2 Aug 2016 23:18:57 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > On Tue, 2 Aug 2016 22:12:33 -0500
> > Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> > 
> > 
> > > Sounds good.  I was thinking I could also add a similar define to
> > > indicate whether an arch passes the return address stack pointer to
> > > ftrace_push_return_trace().  HAVE_FUNCTION_GRAPH_RET_ADDR_PTR?
> > >   
> > 
> > If you are making this function global, might as well make all pass
> > that pointer when you do the conversion. I don't think we need a define
> > to differentiate it.
> > 
> 
> Bah, I was thinking of your ftrace_graph_ret_addr() function. /me needs
> to go to bed.
> 
> Anyway, if we have to add a parameter, we probably need to update all
> the callers anyway. We do need to add a parameter for this, right?

Yeah, we do need to add a parameter to ftrace_push_return_trace().  But
callers which don't implement it could just pass zero like they do with
'fp'.

-- 
Josh

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack  dump reliability issues Steven Rostedt <rostedt@goodmis.org> - 2016-07-30 01:00 +0200
  Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack  dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-07-30 03:00 +0200
    Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack  dump reliability issues Steven Rostedt <rostedt@goodmis.org> - 2016-07-30 04:30 +0200
      Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack  dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-07-30 16:00 +0200
        Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack  dump reliability issues Steven Rostedt <rostedt@goodmis.org> - 2016-08-01 16:30 +0200
          Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack  dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-01 17:40 +0200
            Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack  dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-02 23:10 +0200
              Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack  dump reliability issues Steven Rostedt <rostedt@goodmis.org> - 2016-08-02 23:20 +0200
                Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack  dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-03 00:20 +0200
                Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack  dump reliability issues Steven Rostedt <rostedt@goodmis.org> - 2016-08-03 01:20 +0200
                Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack  dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-03 04:10 +0200
                Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack  dump reliability issues Steven Rostedt <rostedt@goodmis.org> - 2016-08-03 04:40 +0200
                Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack  dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-03 05:00 +0200
                Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack  dump reliability issues Steven Rostedt <rostedt@goodmis.org> - 2016-08-03 05:10 +0200
                Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack  dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-03 05:20 +0200
                Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack  dump reliability issues Steven Rostedt <rostedt@goodmis.org> - 2016-08-03 05:30 +0200
                Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack  dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-03 05:40 +0200
                Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack  dump reliability issues Steven Rostedt <rostedt@goodmis.org> - 2016-08-03 05:50 +0200
                Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack  dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-03 16:30 +0200
                Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack  dump reliability issues Steven Rostedt <rostedt@goodmis.org> - 2016-08-03 05:40 +0200
                Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack  dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-03 05:40 +0200
  Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack  dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-01 18:20 +0200
  Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack  dump reliability issues Steven Rostedt <rostedt@goodmis.org> - 2016-08-01 18:20 +0200
  Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack  dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-01 18:40 +0200
    Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack  dump reliability issues Steven Rostedt <rostedt@goodmis.org> - 2016-08-01 19:00 +0200
  Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack  dump reliability issues Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-01 18:50 +0200

csiph-web