Re: [PATCH] firmware-gsmi: Delete an unnecessary check before the function call "dma_pool_destroy"

From	Mike Waychison <mikew@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] firmware-gsmi: Delete an unnecessary check before the function call "dma_pool_destroy"
Date	2016-08-01 18:40 +0200
Message-ID	<s1opY-ih-43@gated-at.bofh.it> (permalink)
References	(6 earlier) <mSsDN-4wa-63@gated-at.bofh.it> <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <rYmXn-5C2-5@gated-at.bofh.it> <s1kmm-6cP-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Aug 1, 2016 at 5:04 AM, Matt Fleming <matt@codeblueprint.co.uk> wrote:
>
> On Sun, 24 Jul, at 10:27:49AM, SF Markus Elfring wrote:
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Sun, 24 Jul 2016 10:16:56 +0200
> >
> > The dma_pool_destroy() function tests whether its argument is NULL
> > and then returns immediately. Thus the test around the call is not needed.
> >
> > This issue was detected by using the Coccinelle software.
> >
> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> > ---
> >  drivers/firmware/google/gsmi.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
>
> Looks fine to me. If Mike doesn't pick this up I'll take it through
> the EFI tree.

Yes please do.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] firmware-gsmi: Delete an unnecessary check before the  function call "dma_pool_destroy" Matt Fleming <matt@codeblueprint.co.uk> - 2016-08-01 14:20 +0200
  Re: [PATCH] firmware-gsmi: Delete an unnecessary check before the  function call "dma_pool_destroy" Mike Waychison <mikew@google.com> - 2016-08-01 18:40 +0200

csiph-web