Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1395196

Re: [for-next][PATCH 2/2] tracing: Use temp buffer when filtering events

From Alexei Starovoitov <alexei.starovoitov@gmail.com>
Newsgroups linux.kernel
Subject Re: [for-next][PATCH 2/2] tracing: Use temp buffer when filtering events
Date 2016-05-05 17:50 +0200
Message-ID <rvtHj-2xH-1@gated-at.bofh.it> (permalink)
References <rv5vk-4VB-21@gated-at.bofh.it> <rv5vk-4VB-27@gated-at.bofh.it> <rvtnY-2lG-11@gated-at.bofh.it> <rvtxE-2sD-13@gated-at.bofh.it> <rvtxE-2sD-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, May 05, 2016 at 11:35:43AM -0400, Steven Rostedt wrote:
> On Thu, 5 May 2016 11:32:51 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > Think about it, what's the difference if the interrupt came in just
> > before the trace or just after? It still came in the same location with
> > respect to the normal flow of the code. The only difference is, where
> > we recorded it.
> 
> Also, if we used a temp buffer for each one, the same thing would
> happen. The interrupt would be committed first before returning back to
> the interrupted event. Perf does the same thing, but all the time.

yeah. good point. there is no actual 'order' here.
The whole thing looks good to me. 
Acked-by: Alexei Starovoitov <ast@kernel.org>

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[for-next][PATCH 2/2] tracing: Use temp buffer when filtering events Steven Rostedt <rostedt@goodmis.org> - 2016-05-04 16:00 +0200
  Re: [for-next][PATCH 2/2] tracing: Use temp buffer when filtering  events Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2016-05-05 17:30 +0200
    Re: [for-next][PATCH 2/2] tracing: Use temp buffer when filtering  events Steven Rostedt <rostedt@goodmis.org> - 2016-05-05 17:40 +0200
      Re: [for-next][PATCH 2/2] tracing: Use temp buffer when filtering  events Steven Rostedt <rostedt@goodmis.org> - 2016-05-05 17:40 +0200
        Re: [for-next][PATCH 2/2] tracing: Use temp buffer when filtering  events Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2016-05-05 17:50 +0200

csiph-web