Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1395195
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/3] regulator: lp873x: Add support for lp873x PMIC regulators |
| Date | 2016-05-05 17:40 +0200 |
| Message-ID | <rvtxE-2sD-21@gated-at.bofh.it> (permalink) |
| References | <rvjRE-1Ry-7@gated-at.bofh.it> <rvjRE-1Ry-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Thu, May 05, 2016 at 10:40:40AM +0530, Keerthy wrote:
> +static const struct of_device_id of_lp873x_match_tbl[] = {
> + { .compatible = "ti,lp8733-regulators",},
> + { .compatible = "ti,lp8732-regulators",},
> + { .compatible = "ti,lp873x-regulators",},
> + {},
> +};
There should be no need for compatible strings here, we already know
what device this is from the parent. The way we split drivers up for
Linux is something that's internal to Linux and shouldn't be in the
device tree. If we do have explicit compatible strings then they should
(as always) be specific to a device, no wildcards.
Otherwise this looks sensible.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/3] mfd: lp873x: Add lp873x PMIC support Keerthy <j-keerthy@ti.com> - 2016-05-05 07:20 +0200
[PATCH] mfd: lp873x: Add lp873x PMIC support Keerthy <j-keerthy@ti.com> - 2016-05-05 07:20 +0200
Re: [PATCH] mfd: lp873x: Add lp873x PMIC support Manish Badarkhe <badarkhe.manish@gmail.com> - 2016-05-05 10:40 +0200
Re: [PATCH] mfd: lp873x: Add lp873x PMIC support Keerthy <a0393675@ti.com> - 2016-05-06 06:10 +0200
[PATCH 3/3] regulator: lp873x: Add support for lp873x PMIC regulators Keerthy <j-keerthy@ti.com> - 2016-05-05 07:20 +0200
Re: [PATCH 3/3] regulator: lp873x: Add support for lp873x PMIC regulators Mark Brown <broonie@kernel.org> - 2016-05-05 17:40 +0200
Re: [PATCH 3/3] regulator: lp873x: Add support for lp873x PMIC regulators Keerthy <a0393675@ti.com> - 2016-05-06 06:50 +0200
Re: [PATCH 3/3] regulator: lp873x: Add support for lp873x PMIC regulators Mark Brown <broonie@kernel.org> - 2016-05-06 14:10 +0200
Re: [PATCH 3/3] regulator: lp873x: Add support for lp873x PMIC regulators Keerthy <a0393675@ti.com> - 2016-05-06 14:40 +0200
csiph-web