Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1395192

Re: [for-next][PATCH 2/2] tracing: Use temp buffer when filtering events

From Steven Rostedt <rostedt@goodmis.org>
Newsgroups linux.kernel
Subject Re: [for-next][PATCH 2/2] tracing: Use temp buffer when filtering events
Date 2016-05-05 17:40 +0200
Message-ID <rvtxE-2sD-13@gated-at.bofh.it> (permalink)
References <rv5vk-4VB-21@gated-at.bofh.it> <rv5vk-4VB-27@gated-at.bofh.it> <rvtnY-2lG-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, 5 May 2016 08:20:57 -0700
Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:


> tricky :)

Thanks ;-)

> so the buffer is used only for non-recursive events.
> If the 2nd event on the same cpu also needs filtering it will
> be going through normal trace_buffer_lock_reserve() path,
> but then it means such events will be out of order if both
> are accepted, right?
> Is that a concern or not?

Well, what is the order?

Think about it, what's the difference if the interrupt came in just
before the trace or just after? It still came in the same location with
respect to the normal flow of the code. The only difference is, where
we recorded it.

-- Steve

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[for-next][PATCH 2/2] tracing: Use temp buffer when filtering events Steven Rostedt <rostedt@goodmis.org> - 2016-05-04 16:00 +0200
  Re: [for-next][PATCH 2/2] tracing: Use temp buffer when filtering  events Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2016-05-05 17:30 +0200
    Re: [for-next][PATCH 2/2] tracing: Use temp buffer when filtering  events Steven Rostedt <rostedt@goodmis.org> - 2016-05-05 17:40 +0200
      Re: [for-next][PATCH 2/2] tracing: Use temp buffer when filtering  events Steven Rostedt <rostedt@goodmis.org> - 2016-05-05 17:40 +0200
        Re: [for-next][PATCH 2/2] tracing: Use temp buffer when filtering  events Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2016-05-05 17:50 +0200

csiph-web