Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups

From	Olliver Schinagl <oliver@schinagl.nl>
Newsgroups	linux.kernel
Subject	Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups
Date	2016-04-20 11:10 +0200
Message-ID	<rpWj0-5uh-19@gated-at.bofh.it> (permalink)
References	(5 earlier) <rpEcq-7GG-27@gated-at.bofh.it> <rpUKe-3Yt-19@gated-at.bofh.it> <rpVmV-4Cl-3@gated-at.bofh.it> <rpW9k-51U-9@gated-at.bofh.it> <rpW9k-51U-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 20-04-16 10:56, Ricardo Ribalda Delgado wrote:
> Hi
>
> On Wed, Apr 20, 2016 at 10:51 AM, Olliver Schinagl <oliver@schinagl.nl> wrote:
>
>>> As I said before, the reason for this proposal is that the code NEVER
>>> clears PCA963X_MODE2_DMBLNK, only sets it.
>>> Unfortunately I do not have the HW to test this change.
>> The code never clears it, but the hardware does. So we have to set it
>> everytime we enable blink.
> Ok, that was the part I was missing. I was not aware that the hw was
> clearing it.
The devil is in the details :)
> Saving mode2 sounds like a good compromise then.
>
> But I still believe that we should limit the lock to ledout. No matter
> what we do, we cannot have two leds blinking at different frequencies
> on the same chip.
So to save a mutex a little bit, we take the risk that nobody else 
enables the blink or if they do, enable it in the same way?
If it saves so much, then I guess its worth the risk I suppose?
>
>
> Regards
>

Thread

[PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups Olliver Schinagl <oliver@schinagl.nl> - 2016-04-19 09:50 +0200
  [PATCH 5/6] leds: pca963x: Inform the output that it is inverted Olliver Schinagl <oliver@schinagl.nl> - 2016-04-19 09:50 +0200
    Re: [PATCH 5/6] leds: pca963x: Inform the output that it is inverted Rob Herring <robh@kernel.org> - 2016-04-21 17:10 +0200
      Re: [PATCH 5/6] leds: pca963x: Inform the output that it is inverted Olliver Schinagl <oliver@schinagl.nl> - 2016-04-22 14:40 +0200
        Re: [PATCH 5/6] leds: pca963x: Inform the output that it is inverted Rob Herring <robh@kernel.org> - 2016-04-22 15:20 +0200
          Re: [PATCH 5/6] leds: pca963x: Inform the output that it is inverted Olliver Schinagl <oliver@schinagl.nl> - 2016-04-22 17:50 +0200
  Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-04-19 11:30 +0200
    Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and  cleanups Olliver Schinagl <oliver@schinagl.nl> - 2016-04-19 11:50 +0200
      Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-04-19 13:20 +0200
        Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and  cleanups Olliver Schinagl <oliver@schinagl.nl> - 2016-04-19 15:30 +0200
          Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-04-19 15:50 +0200
            Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and  cleanups Olliver Schinagl <oliver@schinagl.nl> - 2016-04-20 09:30 +0200
              Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-04-20 10:10 +0200
                Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and  cleanups Olliver Schinagl <oliver@schinagl.nl> - 2016-04-20 11:00 +0200
                Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-04-20 11:00 +0200
                Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and  cleanups Olliver Schinagl <oliver@schinagl.nl> - 2016-04-20 11:10 +0200
                Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-04-20 11:20 +0200
                Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and  cleanups Olliver Schinagl <oliver@schinagl.nl> - 2016-04-20 12:20 +0200
                Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and  cleanups Olliver Schinagl <oliver@schinagl.nl> - 2016-04-22 09:30 +0200

csiph-web