Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1382241

[PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups

From Olliver Schinagl <oliver@schinagl.nl>
Newsgroups linux.kernel
Subject [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups
Date 2016-04-19 09:50 +0200
Message-ID <rpyA1-3dt-3@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


Using the pca963x for a while, I noticed something that may look like some
i2c accessing issues where sometimes data was incorrectly written to the bus,
possibly because we where not properly locking the i2c reads. Though I'm not
familiar enough with the i2c framework to be certain reads need to be locked
at all. A patch was added to properly lock i2c access more tightly.

Furthermore there was no method to support inverted outputs. This series
adds a property to the device tree to inform the driver that the output
is inverted (active-high vs active-low).

Additionally, this patch set does some cleanups to please checkpatch, and
removes a few magic values.

Olliver Schinagl (6):
  leds: pca963x: Alphabetize headers
  leds: pca963x: Lock i2c r/w access
  leds: pca963x: Add defines and remove some magic values
  leds: pca963x: Reduce magic values
  leds: pca963x: Inform the output that it is inverted
  leds: pca963x: Remove whitespace and checkpatch problems

 Documentation/devicetree/bindings/leds/pca963x.txt |   1 +
 drivers/leds/leds-pca963x.c                        | 243 ++++++++++++++-------
 include/linux/platform_data/leds-pca963x.h         |   1 +
 3 files changed, 171 insertions(+), 74 deletions(-)

-- 
2.8.0.rc3

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups Olliver Schinagl <oliver@schinagl.nl> - 2016-04-19 09:50 +0200
  [PATCH 5/6] leds: pca963x: Inform the output that it is inverted Olliver Schinagl <oliver@schinagl.nl> - 2016-04-19 09:50 +0200
    Re: [PATCH 5/6] leds: pca963x: Inform the output that it is inverted Rob Herring <robh@kernel.org> - 2016-04-21 17:10 +0200
      Re: [PATCH 5/6] leds: pca963x: Inform the output that it is inverted Olliver Schinagl <oliver@schinagl.nl> - 2016-04-22 14:40 +0200
        Re: [PATCH 5/6] leds: pca963x: Inform the output that it is inverted Rob Herring <robh@kernel.org> - 2016-04-22 15:20 +0200
          Re: [PATCH 5/6] leds: pca963x: Inform the output that it is inverted Olliver Schinagl <oliver@schinagl.nl> - 2016-04-22 17:50 +0200
  Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-04-19 11:30 +0200
    Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and  cleanups Olliver Schinagl <oliver@schinagl.nl> - 2016-04-19 11:50 +0200
      Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-04-19 13:20 +0200
        Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and  cleanups Olliver Schinagl <oliver@schinagl.nl> - 2016-04-19 15:30 +0200
          Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-04-19 15:50 +0200
            Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and  cleanups Olliver Schinagl <oliver@schinagl.nl> - 2016-04-20 09:30 +0200
              Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-04-20 10:10 +0200
                Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and  cleanups Olliver Schinagl <oliver@schinagl.nl> - 2016-04-20 11:00 +0200
                Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-04-20 11:00 +0200
                Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and  cleanups Olliver Schinagl <oliver@schinagl.nl> - 2016-04-20 11:10 +0200
                Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-04-20 11:20 +0200
                Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and  cleanups Olliver Schinagl <oliver@schinagl.nl> - 2016-04-20 12:20 +0200
                Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and  cleanups Olliver Schinagl <oliver@schinagl.nl> - 2016-04-22 09:30 +0200

csiph-web