Re: [PATCH 1/5] input: twl6040-vibra: fix DT node memory management

From	"H. Nikolaus Schaller" <hns@goldelico.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/5] input: twl6040-vibra: fix DT node memory management
Date	2016-04-20 11:10 +0200
Message-ID	<rpWj1-5uh-25@gated-at.bofh.it> (permalink)
References	<rpnuV-2F6-7@gated-at.bofh.it> <rpnuW-2F6-13@gated-at.bofh.it> <rpoU2-422-19@gated-at.bofh.it> <rpyA1-3dt-9@gated-at.bofh.it> <rpHjY-1Nv-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> Am 19.04.2016 um 19:06 schrieb Dmitry Torokhov <dmitry.torokhov@gmail.com>:
> 
> On Tue, Apr 19, 2016 at 09:43:08AM +0200, H. Nikolaus Schaller wrote:
>> 
>>> Am 18.04.2016 um 23:22 schrieb Dmitry Torokhov <dmitry.torokhov@gmail.com>:
>>> 
>>> On Mon, Apr 18, 2016 at 09:55:37PM +0200, H. Nikolaus Schaller wrote:
>>>> commit e7ec014a47e4 ("Input: twl6040-vibra - update for device tree support")
>>>> 
>>>> made the separate vibra DT node to a subnode of the twl6040.
>>>> 
>>>> It now calls of_find_node_by_name() to locate the "vibra" subnode.
>>>> This function has a side effect to call of_node_put on() for the twl6040
>>>> parent node passed in as a parameter. This causes trouble later on.
>>>> 
>>>> Solution: we must call of_node_get() before of_find_node_by_name()
>>> 
>>> God, what messed up API.
>> 
>> Yes, indeed. It is opposite to the usual object ownership rule that the code
>> fragment that asks for a handle has to release it.
>> 
>> Usually it does not become obvious because often CONFIG_OF_DYNAMIC=n.
>> This disables all of_node refcounting completely so such bugs remain unnoticed.
>> 
>>> Any chance we can make it a bit more sane and
>>> not drop the reference inside it instead?
>> 
>> Well, if you want to change ~2000 files, test on all platforms and ask Linus
>> for agreement?
> 
> It's not that bad, let's see what DT maintainers say to the patch I
> posted...

Thanks! Would make me more happy a well.

Nikolaus

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/5] input: twl6040-vibra: fix DT node memory management "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-04-18 22:00 +0200
  Re: [PATCH 1/5] input: twl6040-vibra: fix DT node memory management Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-04-18 23:30 +0200
    Re: [PATCH 1/5] input: twl6040-vibra: fix DT node memory management "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-04-19 09:50 +0200
      Re: [PATCH 1/5] input: twl6040-vibra: fix DT node memory management Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-04-19 19:10 +0200
        Re: [PATCH 1/5] input: twl6040-vibra: fix DT node memory management "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-04-20 11:10 +0200

csiph-web