Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups

From	Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups
Date	2016-04-19 15:50 +0200
Message-ID	<rpEcq-7GG-27@gated-at.bofh.it> (permalink)
References	<rpyA1-3dt-3@gated-at.bofh.it> <rpA8O-4wD-9@gated-at.bofh.it> <rpAsa-4Gq-7@gated-at.bofh.it> <rpBRg-615-17@gated-at.bofh.it> <rpDT5-7yn-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi again

On Tue, Apr 19, 2016 at 3:27 PM, Olliver Schinagl <oliver@schinagl.nl> wrote:
> Hey Ricardo,

> Without actually looking at the code right now, but the driver does a
> read/modify/write on the register, and a register is shared among several
> leds. So in that regard, it makes sense and I don't think it's very
> expensive to move the lock, since we have to lock for the write a few lines
> down anyway.

Actually, the code is only making sure that PCA963X_MODE2_DMBLNK is
on. It is never cleared afterwards.

It will be great if you could set that bit on probe and remove those
two lines and verify that it works on real hardware.

The move of the lock can be a bit expensive. i2c writes can take a
while to be performed, this is why only ledout was protected
initially.

Best regards

Thread

[PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups Olliver Schinagl <oliver@schinagl.nl> - 2016-04-19 09:50 +0200
  [PATCH 5/6] leds: pca963x: Inform the output that it is inverted Olliver Schinagl <oliver@schinagl.nl> - 2016-04-19 09:50 +0200
    Re: [PATCH 5/6] leds: pca963x: Inform the output that it is inverted Rob Herring <robh@kernel.org> - 2016-04-21 17:10 +0200
      Re: [PATCH 5/6] leds: pca963x: Inform the output that it is inverted Olliver Schinagl <oliver@schinagl.nl> - 2016-04-22 14:40 +0200
        Re: [PATCH 5/6] leds: pca963x: Inform the output that it is inverted Rob Herring <robh@kernel.org> - 2016-04-22 15:20 +0200
          Re: [PATCH 5/6] leds: pca963x: Inform the output that it is inverted Olliver Schinagl <oliver@schinagl.nl> - 2016-04-22 17:50 +0200
  Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-04-19 11:30 +0200
    Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and  cleanups Olliver Schinagl <oliver@schinagl.nl> - 2016-04-19 11:50 +0200
      Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-04-19 13:20 +0200
        Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and  cleanups Olliver Schinagl <oliver@schinagl.nl> - 2016-04-19 15:30 +0200
          Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-04-19 15:50 +0200
            Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and  cleanups Olliver Schinagl <oliver@schinagl.nl> - 2016-04-20 09:30 +0200
              Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-04-20 10:10 +0200
                Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and  cleanups Olliver Schinagl <oliver@schinagl.nl> - 2016-04-20 11:00 +0200
                Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-04-20 11:00 +0200
                Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and  cleanups Olliver Schinagl <oliver@schinagl.nl> - 2016-04-20 11:10 +0200
                Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-04-20 11:20 +0200
                Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and  cleanups Olliver Schinagl <oliver@schinagl.nl> - 2016-04-20 12:20 +0200
                Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and  cleanups Olliver Schinagl <oliver@schinagl.nl> - 2016-04-22 09:30 +0200

csiph-web