Re: [PATCH 2/5] ftrace perf: Move exclude_kernel tracepoint check to init event

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/5] ftrace perf: Move exclude_kernel tracepoint check to init event
Date	2016-03-23 12:10 +0100
Message-ID	<rfOPL-2sH-1@gated-at.bofh.it> (permalink)
References	<rdkMa-1Kx-7@gated-at.bofh.it> <rdkMa-1Kx-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Mar 16, 2016 at 03:34:30PM +0100, Jiri Olsa wrote:
> We suppress events with attr::exclude_kernel set when
> the event is generated, so following capture will
> give no warning but won't produce any data:
> 
>   $ sudo perf record -e sched:sched_switch:u ls
>   $ sudo /perf script | wc -l
>   0
> 
> Checking the attr::exclude_(kernel|user) at the event
> init time and failing right away for tracepoints from
> uprobes/kprobes and native ones:
> 
>   $ sudo perf record -e sched:sched_switch:u ls
>   Error:
>   The sys_perf_event_open() syscall returned with 22 (Invalid argument) for event (sched:sched_switch).
>   /bin/dmesg may provide additional information.
>   No CONFIG_PERF_EVENTS=y kernel support configured?
> 
>   $ sudo perf record -e probe:sys_read:u ls
>   Error:
>   The sys_perf_event_open() syscall returned with 22 (Invalid argument) for event (probe:sys_read).
>   /bin/dmesg may provide additional information.
>   No CONFIG_PERF_EVENTS=y kernel support configured?
> 
>   $ ./perf record -e probe_ex:main:k ./ex
>   Error:
>   The sys_perf_event_open() syscall returned with 22 (Invalid argument) for event (probe_ex:main).
>   /bin/dmesg may provide additional information.
>   No CONFIG_PERF_EVENTS=y kernel support configured?

Not sure about this one. The previous behaviour suggests
exclude_{user,kernel} is implemented, while the new behaviour says these
flags are not implemented, which is a functional regression.

That is, if all events are from kernel space, and we exclude all kernel
events, 0 is the right answer not an error.

Sure, with uprobes the situation is currently broken, but this isn't a
fix.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/5] ftrace perf: Move exclude_kernel tracepoint check to  init event Peter Zijlstra <peterz@infradead.org> - 2016-03-23 12:10 +0100
  Re: [PATCH 2/5] ftrace perf: Move exclude_kernel tracepoint check to  init event Jiri Olsa <jolsa@redhat.com> - 2016-03-24 11:00 +0100
    Re: [PATCH 2/5] ftrace perf: Move exclude_kernel tracepoint check to  init event Peter Zijlstra <peterz@infradead.org> - 2016-03-24 12:00 +0100
      Re: [PATCH 2/5] ftrace perf: Move exclude_kernel tracepoint check to  init event Jiri Olsa <jolsa@redhat.com> - 2016-03-24 13:30 +0100
        Re: [PATCH 2/5] ftrace perf: Move exclude_kernel tracepoint check to  init event Peter Zijlstra <peterz@infradead.org> - 2016-03-24 14:10 +0100
          Re: [PATCH 2/5] ftrace perf: Move exclude_kernel tracepoint check to  init event Jiri Olsa <jolsa@redhat.com> - 2016-03-24 14:40 +0100

csiph-web