Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1440436

Re: cxl: make base more explicitly non-modular

Show all headers | View raw

On Sun, 2016-03-07 at 20:31:53 UTC, Paul Gortmaker wrote:
> The Kconfig/Makefile currently controlling compilation of this code is:
> 
> drivers/misc/cxl/Kconfig:config CXL_BASE
> drivers/misc/cxl/Kconfig:       bool
> 
> drivers/misc/cxl/Makefile:obj-$(CONFIG_CXL_BASE)          += base.o
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets convert the one module_init into device_initcall so that
> when reading the driver it more clear that it is builtin-only.
> 
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering remains unchanged with this commit.
> 
> We don't replace module.h with init.h since the file is doing
> other modular stuff (module_get/put) even though it is built-in.
> 
> Cc: Ian Munsie <imunsie@au1.ibm.com>
> Cc: Michael Neuling <mikey@neuling.org>
> Cc: linuxppc-dev@lists.ozlabs.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> Acked-by: Ian Munsie <imunsie@au1.ibm.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/e00878be3f414a99234b3c9613

cheers

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cxl: make base more explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-03 22:40 +0200
  Re: [PATCH] cxl: make base more explicitly non-modular Ian Munsie <imunsie@au1.ibm.com> - 2016-07-04 03:50 +0200
  Re: cxl: make base more explicitly non-modular Michael Ellerman <mpe@ellerman.id.au> - 2016-07-11 12:20 +0200

csiph-web