Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1436040 > unrolled thread

[PATCH] cxl: make base more explicitly non-modular

Back to article view | Back to linux.kernel

Contents

  [PATCH] cxl: make base more explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-03 22:40 +0200
    Re: [PATCH] cxl: make base more explicitly non-modular Ian Munsie <imunsie@au1.ibm.com> - 2016-07-04 03:50 +0200
    Re: cxl: make base more explicitly non-modular Michael Ellerman <mpe@ellerman.id.au> - 2016-07-11 12:20 +0200

#1436040 — [PATCH] cxl: make base more explicitly non-modular

The Kconfig/Makefile currently controlling compilation of this code is:

drivers/misc/cxl/Kconfig:config CXL_BASE
drivers/misc/cxl/Kconfig:       bool

drivers/misc/cxl/Makefile:obj-$(CONFIG_CXL_BASE)          += base.o

...meaning that it currently is not being built as a module by anyone.

Lets convert the one module_init into device_initcall so that
when reading the driver it more clear that it is builtin-only.

Since module_init translates to device_initcall in the non-modular
case, the init ordering remains unchanged with this commit.

We don't replace module.h with init.h since the file is doing
other modular stuff (module_get/put) even though it is built-in.

Cc: Ian Munsie <imunsie@au1.ibm.com>
Cc: Michael Neuling <mikey@neuling.org>
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/misc/cxl/base.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/misc/cxl/base.c b/drivers/misc/cxl/base.c
index 9b90ec6c07cd..e6f49aca0035 100644
--- a/drivers/misc/cxl/base.c
+++ b/drivers/misc/cxl/base.c
@@ -114,5 +114,4 @@ static int __init cxl_base_init(void)
 	pr_devel("Found %d cxl device(s)\n", count);
 	return 0;
 }
-
-module_init(cxl_base_init);
+device_initcall(cxl_base_init);
-- 
2.8.4

[toc] | [next] | [standalone]

#1436108

Acked-by: Ian Munsie <imunsie@au1.ibm.com>

[toc] | [prev] | [next] | [standalone]

#1440436 — Re: cxl: make base more explicitly non-modular

On Sun, 2016-03-07 at 20:31:53 UTC, Paul Gortmaker wrote:
> The Kconfig/Makefile currently controlling compilation of this code is:
> 
> drivers/misc/cxl/Kconfig:config CXL_BASE
> drivers/misc/cxl/Kconfig:       bool
> 
> drivers/misc/cxl/Makefile:obj-$(CONFIG_CXL_BASE)          += base.o
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets convert the one module_init into device_initcall so that
> when reading the driver it more clear that it is builtin-only.
> 
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering remains unchanged with this commit.
> 
> We don't replace module.h with init.h since the file is doing
> other modular stuff (module_get/put) even though it is built-in.
> 
> Cc: Ian Munsie <imunsie@au1.ibm.com>
> Cc: Michael Neuling <mikey@neuling.org>
> Cc: linuxppc-dev@lists.ozlabs.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> Acked-by: Ian Munsie <imunsie@au1.ibm.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/e00878be3f414a99234b3c9613

cheers

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web