Re: [PATCH] pwm: atmel: Fix disabling of PWM channels

From	Thierry Reding <thierry.reding@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pwm: atmel: Fix disabling of PWM channels
Date	2016-07-11 12:20 +0200
Message-ID	<rTGtH-5FU-11@gated-at.bofh.it> (permalink)
References	<ryjiq-2bj-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, May 13, 2016 at 01:09:37PM +0200, Guillermo Rodriguez wrote:
> When disabling a PWM channel, the PWM clock was being stopped
> immediately after writing to PWM_DIS. As a result, the disabling
> of the PWM channel did not complete properly, and the PWM output
> might be left at the wrong level.
> 
> Fix this by waiting for the channel to be effectively disabled
> (by checking the PWM_SR register) before disabling the clock.
> 
> Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
> ---
>  drivers/pwm/pwm-atmel.c |   10 ++++++++++
>  1 file changed, 10 insertions(+)

Applied, thanks.

Thierry

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] pwm: atmel: Fix disabling of PWM channels Thierry Reding <thierry.reding@gmail.com> - 2016-07-11 12:20 +0200

csiph-web